mirror of
https://github.com/rustdesk/rustdesk.git
synced 2026-09-05 23:51:04 +03:00
The multiplexed login had replaced `connect_and_login`, so a mapping with the setting off, a peer without the feature, or a listener latched `Legacy` still went through the tunnel's state machine, the capped pre-read and the changed local-EOF rule. Feature off now means the old code: `listen()` keeps its accept arm and `connect_and_login` as they were, and the tunnel is a branch taken only when the setting is on, in `establish_tunnel` with its own `connect_and_login_mux`. The one line the raw path does differently is the target riding with the accept's interface clone instead of the shared handler. `get_port_forward_mux_enabled` had one caller and moves in here, so `common.rs` is untouched. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EZ49AbZJYfm8NTp5yDPMab
569 lines
21 KiB
Rust
569 lines
21 KiB
Rust
use std::sync::{Arc, RwLock};
|
|
|
|
use crate::client::*;
|
|
use crate::port_forward_mux::{Claim, Tunnel, CHANNEL_WINDOW};
|
|
use hbb_common::{
|
|
allow_err, bail,
|
|
config::READ_TIMEOUT,
|
|
futures::{SinkExt, StreamExt},
|
|
log,
|
|
message_proto::*,
|
|
protobuf::Message as _,
|
|
rendezvous_proto::ConnType,
|
|
tcp, timeout,
|
|
tokio::{self, net::TcpStream, sync::mpsc},
|
|
tokio_util::codec::{BytesCodec, Framed},
|
|
ResultType, Stream,
|
|
};
|
|
|
|
fn run_rdp(port: u16, name: &str) {
|
|
std::process::Command::new("cmdkey")
|
|
.arg("/delete:localhost")
|
|
.output()
|
|
.ok();
|
|
let username = std::env::var("rdp_username").unwrap_or_default();
|
|
let password = std::env::var("rdp_password").unwrap_or_default();
|
|
if !username.is_empty() || !password.is_empty() {
|
|
let mut args = vec!["/generic:localhost".to_owned()];
|
|
if !username.is_empty() {
|
|
args.push(format!("/user:{}", username));
|
|
}
|
|
if !password.is_empty() {
|
|
args.push(format!("/pass:{}", password));
|
|
}
|
|
std::process::Command::new("cmdkey")
|
|
.args(&args)
|
|
.output()
|
|
.ok();
|
|
}
|
|
// Keep using /v instead of a generated .rdp file: mstsc then preserves the
|
|
// user's Default.rdp settings and avoids unsigned-file warnings or policies.
|
|
match std::process::Command::new("mstsc")
|
|
.arg(format!("/v:localhost:{}", port))
|
|
.spawn()
|
|
{
|
|
Ok(child) => {
|
|
#[cfg(windows)]
|
|
crate::platform::set_rdp_window_title(child, name.to_owned());
|
|
#[cfg(not(windows))]
|
|
let _ = (child, name);
|
|
}
|
|
Err(err) => log::warn!("Failed to launch mstsc: {}", err),
|
|
}
|
|
}
|
|
|
|
// Show the peer identity with its hostname, using the ID when no alias exists.
|
|
fn rdp_display_name(lc: &Arc<RwLock<LoginConfigHandler>>, id: &str) -> String {
|
|
let lc = lc.read().unwrap();
|
|
let alias = lc
|
|
.options
|
|
.get("alias")
|
|
.map(|s| s.trim())
|
|
.unwrap_or_default();
|
|
let hostname = lc.info.hostname.trim();
|
|
let identity = if !alias.is_empty() { alias } else { id };
|
|
if hostname.is_empty() || hostname == identity {
|
|
identity.to_owned()
|
|
} else {
|
|
format!("{} ({})", identity, hostname)
|
|
}
|
|
}
|
|
|
|
pub async fn listen(
|
|
id: String,
|
|
password: String,
|
|
port: i32,
|
|
interface: impl Interface,
|
|
ui_receiver: mpsc::UnboundedReceiver<Data>,
|
|
key: &str,
|
|
token: &str,
|
|
lc: Arc<RwLock<LoginConfigHandler>>,
|
|
remote_host: String,
|
|
remote_port: i32,
|
|
) -> ResultType<()> {
|
|
let listener = tcp::new_listener(format!("127.0.0.1:{}", port), true).await?;
|
|
let addr = listener.local_addr()?;
|
|
log::info!("listening on port {:?}", addr);
|
|
let is_rdp = port == 0;
|
|
if is_rdp {
|
|
run_rdp(addr.port(), &rdp_display_name(&lc, &id));
|
|
}
|
|
let mut ui_receiver = ui_receiver;
|
|
// One tunnel per mapping; the listener drops it on its way out, and that
|
|
// ends the tunnel.
|
|
let tunnel = Tunnel::new();
|
|
loop {
|
|
tokio::select! {
|
|
Ok((forward, addr)) = listener.accept() => {
|
|
log::info!("new connection from {:?}", addr);
|
|
// A multiplexed mapping takes the connection on its tunnel, or
|
|
// probes for one on its first accept. Everything else, the
|
|
// setting off or a peer without the feature, is the raw pipe
|
|
// below, as it always was.
|
|
let claim = if mux_enabled() { tunnel.claim() } else { Claim::Legacy };
|
|
match claim {
|
|
Claim::Muxed(handle) => {
|
|
if let Err(e) = handle.open(&remote_host, remote_port, forward, Vec::new()) {
|
|
log::debug!("cannot open channel for {:?}: {}", addr, e);
|
|
}
|
|
continue;
|
|
}
|
|
Claim::Claimed => {
|
|
if establish_tunnel(&tunnel, &id, &password, &mut ui_receiver, &interface, forward, addr, key, token, is_rdp, &remote_host, remote_port).await {
|
|
break;
|
|
}
|
|
continue;
|
|
}
|
|
Claim::Legacy => {}
|
|
}
|
|
// The target rides with this accept's interface clone, so two
|
|
// mappings logging in at once cannot overwrite each other's.
|
|
let interface = interface.with_port_forward(login_target(&remote_host, remote_port, false));
|
|
let id = id.clone();
|
|
let password = password.clone();
|
|
let mut forward = Framed::new(forward, BytesCodec::new());
|
|
let mut close_port_forward = false;
|
|
match connect_and_login(&id, &password, &mut ui_receiver, interface.clone(), &mut forward, key, token, is_rdp, &mut close_port_forward).await {
|
|
Ok(Some(stream)) => {
|
|
let interface = interface.clone();
|
|
tokio::spawn(async move {
|
|
if let Err(err) = run_forward(forward, stream).await {
|
|
interface.msgbox("error", "Error", &err.to_string(), "");
|
|
}
|
|
log::info!("connection from {:?} closed", addr);
|
|
});
|
|
}
|
|
_ if close_port_forward => {
|
|
break;
|
|
}
|
|
Err(err) => {
|
|
interface.on_establish_connection_error(err.to_string());
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
d = ui_receiver.recv() => {
|
|
match d {
|
|
Some(Data::Close) => {
|
|
break;
|
|
}
|
|
Some(Data::NewRDP) => {
|
|
println!("receive run_rdp from ui_receiver");
|
|
run_rdp(addr.port(), &rdp_display_name(&lc, &id));
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
async fn connect_and_login(
|
|
id: &str,
|
|
password: &str,
|
|
ui_receiver: &mut mpsc::UnboundedReceiver<Data>,
|
|
interface: impl Interface,
|
|
forward: &mut Framed<TcpStream, BytesCodec>,
|
|
key: &str,
|
|
token: &str,
|
|
is_rdp: bool,
|
|
close_port_forward: &mut bool,
|
|
) -> ResultType<Option<Stream>> {
|
|
let conn_type = if is_rdp {
|
|
ConnType::RDP
|
|
} else {
|
|
ConnType::PORT_FORWARD
|
|
};
|
|
let ((mut stream, direct, _pk, _kcp, _stream_type), (feedback, rendezvous_server)) =
|
|
Client::start(id, key, token, conn_type, interface.clone()).await?;
|
|
interface.update_direct(Some(direct));
|
|
if !stream.is_secured() && !crate::common::is_direct_ip_access(id) {
|
|
if !confirm_insecure_connection(&interface, ui_receiver).await {
|
|
*close_port_forward = true;
|
|
return Ok(None);
|
|
}
|
|
}
|
|
let mut buffer = Vec::new();
|
|
let mut received = false;
|
|
|
|
let _keep_it = hc_connection(feedback, rendezvous_server, token).await;
|
|
|
|
loop {
|
|
tokio::select! {
|
|
res = timeout(READ_TIMEOUT, stream.next()) => match res {
|
|
Err(_) => {
|
|
bail!("Timeout");
|
|
}
|
|
Ok(Some(Ok(bytes))) => {
|
|
if !received {
|
|
received = true;
|
|
interface.update_received(true);
|
|
}
|
|
let msg_in = Message::parse_from_bytes(&bytes)?;
|
|
match msg_in.union {
|
|
Some(message::Union::Hash(hash)) => {
|
|
if !interface.handle_hash(password, hash, &mut stream).await {
|
|
return Ok(None);
|
|
}
|
|
}
|
|
Some(message::Union::LoginResponse(lr)) => match lr.union {
|
|
Some(login_response::Union::Error(err)) => {
|
|
if !interface.handle_login_error(&err) {
|
|
return Ok(None);
|
|
}
|
|
}
|
|
Some(login_response::Union::PeerInfo(pi)) => {
|
|
interface.handle_peer_info(pi);
|
|
break;
|
|
}
|
|
_ => {}
|
|
}
|
|
Some(message::Union::TestDelay(t)) => {
|
|
interface.handle_test_delay(t, &mut stream).await;
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
Ok(Some(Err(err))) => {
|
|
bail!("Connection closed: {}", err);
|
|
}
|
|
_ => {
|
|
bail!("Reset by the peer");
|
|
}
|
|
},
|
|
d = ui_receiver.recv() => {
|
|
match d {
|
|
Some(Data::Login((os_username, os_password, password, remember))) => {
|
|
interface.handle_login_from_ui(os_username, os_password, password, remember, &mut stream).await;
|
|
}
|
|
Some(Data::Message(msg)) => {
|
|
allow_err!(stream.send(&msg).await);
|
|
}
|
|
_ => {}
|
|
}
|
|
},
|
|
res = forward.next() => {
|
|
if let Some(Ok(bytes)) = res {
|
|
buffer.extend(bytes);
|
|
} else {
|
|
return Ok(None);
|
|
}
|
|
},
|
|
}
|
|
}
|
|
stream.set_raw();
|
|
if !buffer.is_empty() {
|
|
allow_err!(stream.send_bytes(buffer.into()).await);
|
|
}
|
|
Ok(Some(stream))
|
|
}
|
|
|
|
/// The first accept of a multiplexed mapping. It logs in asking for the
|
|
/// tunnel, and the peer's answer fixes this listener's mode until it closes:
|
|
/// a peer with the feature gets a tunnel every later accept joins, one
|
|
/// without gets today's raw pipe for this connection and `Legacy` for the
|
|
/// rest. Re-adding the mapping is how a user picks up an upgraded peer;
|
|
/// nothing switches modes underneath live connections. Returns `true` when
|
|
/// the listener should stop.
|
|
async fn establish_tunnel(
|
|
tunnel: &Tunnel,
|
|
id: &str,
|
|
password: &str,
|
|
ui_receiver: &mut mpsc::UnboundedReceiver<Data>,
|
|
interface: &impl Interface,
|
|
forward: TcpStream,
|
|
addr: std::net::SocketAddr,
|
|
key: &str,
|
|
token: &str,
|
|
is_rdp: bool,
|
|
remote_host: &str,
|
|
remote_port: i32,
|
|
) -> bool {
|
|
let interface = interface.with_port_forward(login_target(remote_host, remote_port, true));
|
|
let mut forward = Framed::new(forward, BytesCodec::new());
|
|
let mut close_port_forward = false;
|
|
match connect_and_login_mux(id, password, ui_receiver, interface.clone(), &mut forward, key, token, is_rdp, &mut close_port_forward).await {
|
|
Ok(Some(outcome)) if outcome.mux => {
|
|
let handle = tunnel.set_muxed(outcome.stream, interface.clone());
|
|
if !outcome.local_eof {
|
|
let (socket, prebuf) = take_socket(forward, outcome.prebuf);
|
|
if let Err(e) = handle.open(remote_host, remote_port, socket, prebuf) {
|
|
log::debug!("cannot open channel for {:?}: {}", addr, e);
|
|
}
|
|
}
|
|
}
|
|
Ok(Some(outcome)) => {
|
|
tunnel.set_legacy();
|
|
if outcome.local_eof {
|
|
log::debug!("legacy peer and local {:?} already gone", addr);
|
|
} else {
|
|
run_legacy(outcome, forward, addr, interface.clone());
|
|
}
|
|
}
|
|
_ if close_port_forward => {
|
|
tunnel.set_failed();
|
|
return true;
|
|
}
|
|
Err(err) => {
|
|
tunnel.set_failed();
|
|
interface.on_establish_connection_error(err.to_string());
|
|
}
|
|
_ => tunnel.set_failed(),
|
|
}
|
|
false
|
|
}
|
|
|
|
/// `connect_and_login` for a mapping that wants the tunnel: the login asks
|
|
/// for it, the pre-read stops at one window rather than growing without
|
|
/// bound, and a local EOF no longer ends the login, since the tunnel may
|
|
/// still be wanted. It reports what the peer answered rather than a raw
|
|
/// stream, because the caller's next step depends on it.
|
|
async fn connect_and_login_mux(
|
|
id: &str,
|
|
password: &str,
|
|
ui_receiver: &mut mpsc::UnboundedReceiver<Data>,
|
|
interface: impl Interface,
|
|
forward: &mut Framed<TcpStream, BytesCodec>,
|
|
key: &str,
|
|
token: &str,
|
|
is_rdp: bool,
|
|
close_port_forward: &mut bool,
|
|
) -> ResultType<Option<LoginOutcome>> {
|
|
let conn_type = if is_rdp {
|
|
ConnType::RDP
|
|
} else {
|
|
ConnType::PORT_FORWARD
|
|
};
|
|
let ((mut stream, direct, _pk, _kcp, _stream_type), (feedback, rendezvous_server)) =
|
|
Client::start(id, key, token, conn_type, interface.clone()).await?;
|
|
interface.update_direct(Some(direct));
|
|
if !stream.is_secured() && !crate::common::is_direct_ip_access(id) {
|
|
if !confirm_insecure_connection(&interface, ui_receiver).await {
|
|
*close_port_forward = true;
|
|
return Ok(None);
|
|
}
|
|
}
|
|
let mut buffer = Vec::new();
|
|
let mut local_eof = false;
|
|
let mux;
|
|
let mut received = false;
|
|
let mut challenge = None;
|
|
let mut pending_login = None;
|
|
|
|
let _keep_it = hc_connection(feedback, rendezvous_server, token).await;
|
|
|
|
loop {
|
|
tokio::select! {
|
|
res = timeout(READ_TIMEOUT, stream.next()) => match res {
|
|
Err(_) => {
|
|
bail!("Timeout");
|
|
}
|
|
Ok(Some(Ok(bytes))) => {
|
|
if !received {
|
|
received = true;
|
|
interface.update_received(true);
|
|
}
|
|
let msg_in = Message::parse_from_bytes(&bytes)?;
|
|
match msg_in.union {
|
|
Some(message::Union::Hash(hash)) => {
|
|
challenge = Some(hash.clone());
|
|
if !hash_arrived(&interface, password, hash, pending_login.take(), remote_host, remote_port, &mut stream).await {
|
|
return Ok(None);
|
|
}
|
|
}
|
|
Some(message::Union::LoginResponse(lr)) => match lr.union {
|
|
Some(login_response::Union::Error(err)) => {
|
|
if !interface.handle_login_error(&err) {
|
|
return Ok(None);
|
|
}
|
|
}
|
|
Some(login_response::Union::PeerInfo(pi)) => {
|
|
mux = peer_supports_mux(&pi);
|
|
interface.handle_peer_info(pi);
|
|
break;
|
|
}
|
|
_ => {}
|
|
}
|
|
Some(message::Union::TestDelay(t)) => {
|
|
interface.handle_test_delay(t, &mut stream).await;
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
Ok(Some(Err(err))) => {
|
|
bail!("Connection closed: {}", err);
|
|
}
|
|
_ => {
|
|
bail!("Reset by the peer");
|
|
}
|
|
},
|
|
d = ui_receiver.recv() => {
|
|
match d {
|
|
Some(Data::Login(login)) => match &challenge {
|
|
Some(hash) => login_from_ui(&interface, hash, login, remote_host, remote_port, &mut stream).await,
|
|
None => pending_login = Some(login),
|
|
},
|
|
Some(Data::Message(msg)) => {
|
|
allow_err!(stream.send(&msg).await);
|
|
}
|
|
_ => {}
|
|
}
|
|
},
|
|
// Stop pulling once the pre-read buffer is a window deep; the
|
|
// rest waits in the kernel until the channel opens. A local EOF
|
|
// no longer aborts the login: the tunnel may still be wanted.
|
|
res = forward.next(), if !local_eof && buffer.len() < CHANNEL_WINDOW as usize => {
|
|
if let Some(Ok(bytes)) = res {
|
|
buffer.extend(bytes);
|
|
} else {
|
|
local_eof = true;
|
|
}
|
|
},
|
|
}
|
|
}
|
|
Ok(Some(LoginOutcome {
|
|
stream,
|
|
mux,
|
|
prebuf: buffer,
|
|
local_eof,
|
|
}))
|
|
}
|
|
|
|
/// Today's raw pipe, for peers without multiplexing.
|
|
fn run_legacy(
|
|
outcome: LoginOutcome,
|
|
forward: Framed<TcpStream, BytesCodec>,
|
|
addr: std::net::SocketAddr,
|
|
interface: impl Interface,
|
|
) {
|
|
let mut stream = outcome.stream;
|
|
let prebuf = outcome.prebuf;
|
|
tokio::spawn(async move {
|
|
stream.set_raw();
|
|
if !prebuf.is_empty() {
|
|
allow_err!(stream.send_bytes(prebuf.into()).await);
|
|
}
|
|
if let Err(err) = run_forward(forward, stream).await {
|
|
interface.msgbox("error", "Error", &err.to_string(), "");
|
|
}
|
|
log::info!("connection from {:?} closed", addr);
|
|
});
|
|
}
|
|
|
|
struct LoginOutcome {
|
|
stream: Stream,
|
|
mux: bool,
|
|
prebuf: Vec<u8>,
|
|
local_eof: bool,
|
|
}
|
|
|
|
/// The target this accept's login asks for. It travels with the interface
|
|
/// clone rather than through the shared `LoginConfigHandler`, so mappings
|
|
/// logging in at the same time cannot overwrite each other's target.
|
|
fn login_target(host: &str, port: i32, multiplex: bool) -> PortForward {
|
|
PortForward {
|
|
host: host.to_owned(),
|
|
port,
|
|
multiplex,
|
|
..Default::default()
|
|
}
|
|
}
|
|
|
|
fn peer_supports_mux(pi: &PeerInfo) -> bool {
|
|
pi.features.as_ref().map(|f| f.port_forward_mux).unwrap_or(false)
|
|
}
|
|
|
|
/// `into_inner()` would drop bytes the codec pulled but never yielded.
|
|
fn take_socket(forward: Framed<TcpStream, BytesCodec>, mut prebuf: Vec<u8>) -> (TcpStream, Vec<u8>) {
|
|
let parts = forward.into_parts();
|
|
prebuf.extend_from_slice(&parts.read_buf);
|
|
(parts.io, prebuf)
|
|
}
|
|
|
|
/// The controlling side's `enable-port-forward-mux`: on unless set to `N`.
|
|
fn mux_enabled() -> bool {
|
|
use hbb_common::config::{keys, option2bool, LocalConfig};
|
|
option2bool(
|
|
keys::OPTION_ENABLE_PORT_FORWARD_MUX,
|
|
&LocalConfig::get_option(keys::OPTION_ENABLE_PORT_FORWARD_MUX),
|
|
)
|
|
}
|
|
|
|
async fn run_forward(forward: Framed<TcpStream, BytesCodec>, stream: Stream) -> ResultType<()> {
|
|
log::info!("new port forwarding connection started");
|
|
let mut forward = forward;
|
|
let mut stream = stream;
|
|
loop {
|
|
tokio::select! {
|
|
res = forward.next() => {
|
|
if let Some(Ok(bytes)) = res {
|
|
allow_err!(stream.send_bytes(bytes.into()).await);
|
|
} else {
|
|
break;
|
|
}
|
|
},
|
|
res = stream.next() => {
|
|
if let Some(Ok(bytes)) = res {
|
|
allow_err!(forward.send(bytes).await);
|
|
} else {
|
|
break;
|
|
}
|
|
},
|
|
}
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn peer_supports_mux_reads_the_features_bit() {
|
|
let mut pi = PeerInfo::new();
|
|
assert!(!peer_supports_mux(&pi));
|
|
pi.features = Some(Features { port_forward_mux: false, ..Default::default() }).into();
|
|
assert!(!peer_supports_mux(&pi));
|
|
pi.features = Some(Features { port_forward_mux: true, ..Default::default() }).into();
|
|
assert!(peer_supports_mux(&pi));
|
|
}
|
|
|
|
#[test]
|
|
fn port_forward_mux_defaults_to_on() {
|
|
use hbb_common::config::{keys, option2bool};
|
|
// option2bool's fallback branch is also "on unless N", so the value
|
|
// assertions below would pass for a prefixless key too. The `enable-`
|
|
// prefix is what actually guarantees the default, and renaming the key
|
|
// to an `allow-` one would silently flip it — pin the prefix itself.
|
|
assert!(keys::OPTION_ENABLE_PORT_FORWARD_MUX.starts_with("enable-"));
|
|
assert!(option2bool(keys::OPTION_ENABLE_PORT_FORWARD_MUX, ""));
|
|
assert!(option2bool(keys::OPTION_ENABLE_PORT_FORWARD_MUX, "Y"));
|
|
assert!(!option2bool(keys::OPTION_ENABLE_PORT_FORWARD_MUX, "N"));
|
|
}
|
|
|
|
#[test]
|
|
fn take_socket_hands_back_a_working_socket_and_the_prebuf() {
|
|
use hbb_common::tokio::io::{AsyncReadExt, AsyncWriteExt};
|
|
let rt = tokio::runtime::Builder::new_current_thread().enable_all().build().unwrap();
|
|
rt.block_on(async {
|
|
let l = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
|
|
let addr = l.local_addr().unwrap();
|
|
let mut client = TcpStream::connect(addr).await.unwrap();
|
|
let (server, _) = l.accept().await.unwrap();
|
|
let mut framed = Framed::new(server, BytesCodec::new());
|
|
client.write_all(b"abc").await.unwrap();
|
|
// Read through the codec, as connect_and_login does during login.
|
|
let pulled = framed.next().await.unwrap().unwrap();
|
|
assert_eq!(&pulled[..], b"abc");
|
|
let (mut sock, prebuf) = take_socket(framed, pulled.to_vec());
|
|
assert_eq!(prebuf, b"abc".to_vec());
|
|
// Bytes written after the handoff arrive on the bare socket.
|
|
client.write_all(b"def").await.unwrap();
|
|
let mut buf = [0u8; 3];
|
|
sock.read_exact(&mut buf).await.unwrap();
|
|
assert_eq!(&buf, b"def");
|
|
});
|
|
}
|
|
}
|