basic enter hook command

Cargo.lock

@@ -1284,7 +1284,7 @@ dependencies = [
 
 [[package]]
 name = "lan-mouse"
-version = "0.8.0"
+version = "0.7.3"
 dependencies = [
  "anyhow",
  "ashpd",
@@ -1292,7 +1292,6 @@ dependencies = [
  "async-trait",
  "clap",
  "core-graphics",
- "endi",
  "env_logger",
  "futures",
  "futures-core",

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "lan-mouse"
 description = "Software KVM Switch / mouse & keyboard sharing software for Local Area Networks"
-version = "0.8.0"
+version = "0.7.3"
 edition = "2021"
 license = "GPL-3.0-or-later"
 repository = "https://github.com/ferdinandschober/lan-mouse"
@@ -35,7 +35,6 @@ once_cell = "1.19.0"
 num_enum = "0.7.2"
 hostname = "0.4.0"
 slab = "0.4.9"
-endi = "1.1.0"
 
 [target.'cfg(unix)'.dependencies]
 libc = "0.2.148"

README.md

@@ -69,15 +69,7 @@ Precompiled release binaries for Windows, MacOS and Linux are available in the [
 For Windows, the depenedencies are included in the .zip file, for other operating systems see [Installing Dependencies](#installing-dependencies).
 
 ### Arch Linux
-
-Lan Mouse can be installed from the [official repositories](https://archlinux.org/packages/extra/x86_64/lan-mouse/):
-
-```sh
-pacman -S lan-mouse
-```
-
-It is also available on the AUR:
-
+Lan Mouse is available on the AUR:
 ```sh
 # git version (includes latest changes)
 paru -S lan-mouse-git

flake.lock

@@ -20,11 +20,11 @@
     },
     "nixpkgs": {
       "locked": {
-        "lastModified": 1716293225,
-        "narHash": "sha256-pU9ViBVE3XYb70xZx+jK6SEVphvt7xMTbm6yDIF4xPs=",
+        "lastModified": 1710806803,
+        "narHash": "sha256-qrxvLS888pNJFwJdK+hf1wpRCSQcqA6W5+Ox202NDa0=",
         "owner": "nixos",
         "repo": "nixpkgs",
-        "rev": "3eaeaeb6b1e08a016380c279f8846e0bd8808916",
+        "rev": "b06025f1533a1e07b6db3e75151caa155d1c7eb3",
         "type": "github"
       },
       "original": {
@@ -48,11 +48,11 @@
         ]
       },
       "locked": {
-        "lastModified": 1716257780,
-        "narHash": "sha256-R+NjvJzKEkTVCmdrKRfPE4liX/KMGVqGUwwS5H8ET8A=",
+        "lastModified": 1710987136,
+        "narHash": "sha256-Q8GRdlAIKZ8tJUXrbcRO1pA33AdoPfTUirsSnmGQnOU=",
         "owner": "oxalica",
         "repo": "rust-overlay",
-        "rev": "4e5e3d2c5c9b2721bd266f9e43c14e96811b89d2",
+        "rev": "97596b54ac34ad8184ca1eef44b1ec2e5c2b5f9e",
         "type": "github"
       },
       "original": {

nix/default.nix

@@ -2,14 +2,10 @@
   rustPlatform,
   lib,
   pkgs,
-}: let
-  cargoToml = builtins.fromTOML (builtins.readFile ../Cargo.toml);
-  pname = cargoToml.package.name;
-  version = cargoToml.package.version;
-in
+}:
 rustPlatform.buildRustPackage {
-  pname = pname;
-  version = version;
+  pname = "lan-mouse";
+  version = "0.7.0";
 
   nativeBuildInputs = with pkgs; [
     pkg-config
@@ -27,7 +23,7 @@ rustPlatform.buildRustPackage {
   ];
 
   src = builtins.path {
-    name = pname;
+    name = "lan-mouse";
     path = lib.cleanSource ../.;
   };
 
@@ -42,7 +38,7 @@ rustPlatform.buildRustPackage {
       Lan Mouse is a mouse and keyboard sharing software similar to universal-control on Apple devices. It allows for using multiple pcs with a single set of mouse and keyboard. This is also known as a Software KVM switch.
       The primary target is Wayland on Linux but Windows and MacOS and Linux on Xorg have partial support as well (see below for more details).
     '';
-    mainProgram = pname;
+    mainProgram = "lan-mouse";
     platforms = platforms.all;
   };
 }

src/capture/wayland.rs

@@ -111,7 +111,6 @@ struct State {
     qh: QueueHandle<Self>,
     pending_events: VecDeque<(ClientHandle, Event)>,
     output_info: Vec<(WlOutput, OutputInfo)>,
-    scroll_discrete_pending: bool,
 }
 
 struct Inner {
@@ -146,8 +145,8 @@ impl Window {
         let g = &state.g;
 
         let (width, height) = match pos {
-            Position::Left | Position::Right => (2, size.1 as u32),
-            Position::Top | Position::Bottom => (size.0 as u32, 2),
+            Position::Left | Position::Right => (1, size.1 as u32),
+            Position::Top | Position::Bottom => (size.0 as u32, 1),
         };
         let mut file = tempfile::tempfile().unwrap();
         draw(&mut file, (width, height));
@@ -352,7 +351,6 @@ impl WaylandInputCapture {
             read_guard: None,
             pending_events: VecDeque::new(),
             output_info: vec![],
-            scroll_discrete_pending: false,
         };
 
         // dispatch registry to () again, in order to read all wl_outputs
@@ -754,25 +752,17 @@ impl Dispatch<WlPointer, ()> for State {
             }
             wl_pointer::Event::Axis { time, axis, value } => {
                 let (_, client) = app.focused.as_ref().unwrap();
-                if app.scroll_discrete_pending {
-                    // each axisvalue120 event is coupled with
-                    // a corresponding axis event, which needs to
-                    // be ignored to not duplicate the scrolling
-                    app.scroll_discrete_pending = false;
-                } else {
-                    app.pending_events.push_back((
-                        *client,
-                        Event::Pointer(PointerEvent::Axis {
-                            time,
-                            axis: u32::from(axis) as u8,
-                            value,
-                        }),
-                    ));
-                }
+                app.pending_events.push_back((
+                    *client,
+                    Event::Pointer(PointerEvent::Axis {
+                        time,
+                        axis: u32::from(axis) as u8,
+                        value,
+                    }),
+                ));
             }
             wl_pointer::Event::AxisValue120 { axis, value120 } => {
                 let (_, client) = app.focused.as_ref().unwrap();
-                app.scroll_discrete_pending = true;
                 app.pending_events.push_back((
                     *client,
                     Event::Pointer(PointerEvent::AxisDiscrete120 {

src/capture/windows.rs

@@ -96,7 +96,8 @@ unsafe fn get_event_tid() -> Option<u32> {
 static mut ENTRY_POINT: (i32, i32) = (0, 0);
 
 fn to_mouse_event(wparam: WPARAM, lparam: LPARAM) -> Option<PointerEvent> {
-    let mouse_low_level: MSLLHOOKSTRUCT = unsafe { *(lparam.0 as *const MSLLHOOKSTRUCT) };
+    let mouse_low_level: MSLLHOOKSTRUCT =
+        unsafe { *std::mem::transmute::<LPARAM, *const MSLLHOOKSTRUCT>(lparam) };
     match wparam {
         WPARAM(p) if p == WM_LBUTTONDOWN as usize => Some(PointerEvent::Button {
             time: 0,
@@ -140,7 +141,7 @@ fn to_mouse_event(wparam: WPARAM, lparam: LPARAM) -> Option<PointerEvent> {
         },
         WPARAM(p) if p == WM_MOUSEWHEEL as usize => Some(PointerEvent::AxisDiscrete120 {
             axis: 0,
-            value: -(mouse_low_level.mouseData as i32 >> 16),
+            value: -(mouse_low_level.mouseData as i32),
         }),
         WPARAM(p) if p == WM_XBUTTONDOWN as usize || p == WM_XBUTTONUP as usize => {
             let hb = mouse_low_level.mouseData >> 16;
@@ -166,7 +167,8 @@ fn to_mouse_event(wparam: WPARAM, lparam: LPARAM) -> Option<PointerEvent> {
 }
 
 unsafe fn to_key_event(wparam: WPARAM, lparam: LPARAM) -> Option<KeyboardEvent> {
-    let kybrdllhookstruct: KBDLLHOOKSTRUCT = *(lparam.0 as *const KBDLLHOOKSTRUCT);
+    let kybrdllhookstruct: KBDLLHOOKSTRUCT =
+        *std::mem::transmute::<LPARAM, *const KBDLLHOOKSTRUCT>(lparam);
     let mut scan_code = kybrdllhookstruct.scanCode;
     log::trace!("scan_code: {scan_code}");
     if kybrdllhookstruct.flags.contains(LLKHF_EXTENDED) {
@@ -245,7 +247,8 @@ unsafe fn check_client_activation(wparam: WPARAM, lparam: LPARAM) -> bool {
     if wparam.0 != WM_MOUSEMOVE as usize {
         return ACTIVE_CLIENT.is_some();
     }
-    let mouse_low_level: MSLLHOOKSTRUCT = *(lparam.0 as *const MSLLHOOKSTRUCT);
+    let mouse_low_level: MSLLHOOKSTRUCT =
+        unsafe { *std::mem::transmute::<LPARAM, *const MSLLHOOKSTRUCT>(lparam) };
     static mut PREV_POS: Option<(i32, i32)> = None;
     let curr_pos = (mouse_low_level.pt.x, mouse_low_level.pt.y);
     let prev_pos = PREV_POS.unwrap_or(curr_pos);

src/emulate/wlroots.rs

@@ -182,8 +182,7 @@ impl VirtualInput {
                     }
                     PointerEvent::AxisDiscrete120 { axis, value } => {
                         let axis: Axis = (axis as u32).try_into()?;
-                        self.pointer
-                            .axis_discrete(0, axis, value as f64 / 6., value / 120);
+                        self.pointer.axis(0, axis, (value / 15) as f64);
                         self.pointer.frame();
                     }
                     PointerEvent::Frame {} => self.pointer.frame(),

src/frontend/gtk.rs

@@ -11,7 +11,6 @@ use std::{
 use crate::frontend::{gtk::window::Window, FrontendRequest};
 
 use adw::Application;
-use endi::{Endian, ReadBytes};
 use gtk::{
     gdk::Display, glib::clone, prelude::*, subclass::prelude::ObjectSubclassIsExt, IconTheme,
 };
@@ -86,14 +85,16 @@ fn build_ui(app: &Application) {
     gio::spawn_blocking(move || {
         match loop {
             // read length
-            let len = match rx.read_u64(Endian::Big) {
-                Ok(l) => l,
+            let mut len = [0u8; 8];
+            match rx.read_exact(&mut len) {
+                Ok(_) => (),
                 Err(e) if e.kind() == ErrorKind::UnexpectedEof => break Ok(()),
                 Err(e) => break Err(e),
             };
+            let len = usize::from_be_bytes(len);
 
             // read payload
-            let mut buf = vec![0u8; len as usize];
+            let mut buf = vec![0u8; len];
             match rx.read_exact(&mut buf) {
                 Ok(_) => (),
                 Err(e) if e.kind() == ErrorKind::UnexpectedEof => break Ok(()),

src/frontend/gtk/window.rs

@@ -10,7 +10,6 @@ use std::net::TcpStream;
 
 use adw::prelude::*;
 use adw::subclass::prelude::*;
-use endi::{Endian, WriteBytes};
 use glib::{clone, Object};
 use gtk::{
     gio,
@@ -266,7 +265,8 @@ impl Window {
         let mut stream = self.imp().stream.borrow_mut();
         let stream = stream.as_mut().unwrap();
         let bytes = json.as_bytes();
-        if let Err(e) = stream.write_u64(Endian::Big, bytes.len() as u64) {
+        let len = bytes.len().to_be_bytes();
+        if let Err(e) = stream.write(&len) {
             log::error!("error sending message: {e}");
         };
         if let Err(e) = stream.write(bytes) {

src/scancode.rs

@@ -3,8 +3,6 @@ use serde::{Deserialize, Serialize};
 
 /*
  * https://learn.microsoft.com/en-us/windows/win32/inputdev/about-keyboard-input
- * https://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf
- * https://kbd-project.org/docs/scancodes/scancodes-1.html
  */
 #[repr(u32)]
 #[derive(Debug, Clone, Copy, TryFromPrimitive)]
@@ -122,15 +120,15 @@ pub enum Windows {
     KeyF21 = 0x006C,
     KeyF22 = 0x006D,
     KeyF23 = 0x006E,
-    KeyF24 = 0x0076, // KeyLANG5
+    KeyF24 = 0x0076,
     KeypadComma = 0x007E,
     KeyInternational1 = 0x0073,
     KeyInternational2 = 0x0070,
-    KeyInternational3 = 0x007D, // typo in doc -> its Int'l 3 not Int'l 2
+    KeyInternational3 = 0x007D,
     #[allow(dead_code)]
-    KeyInternational4 = 0x0079,
+    KeyInternational4 = 0x0079, // FIXME unused
     #[allow(dead_code)]
-    KeyInternational5 = 0x007B,
+    KeyInternational5 = 0x007B, // FIXME unused
     // KeyInternational6 = 0x005C,
     KeyLANG1 = 0x0072,
     KeyLANG2 = 0x0071,
@@ -143,7 +141,6 @@ pub enum Windows {
     KeyLeftGUI = 0xE05B,
     KeyRightCtrl = 0xE01D,
     KeyRightShift = 0x0036,
-    KeyFakeRightShift = 0xE036,
     KeyRightAlt = 0xE038,
     KeyRightGUI = 0xE05C,
     KeyScanNextTrack = 0xE019,
@@ -296,7 +293,7 @@ pub enum Linux {
     KeyPause = 119,
     KeyScale = 120, /* AL Compiz Scale (Expose) */
     KeyKpcomma = 121,
-    KeyHanguel = 122,
+    KeyHangeul = 122,
     // KEY_HANGUEL = KeyHangeul,
     KeyHanja = 123,
     KeyYen = 124,
@@ -521,16 +518,16 @@ impl TryFrom<Linux> for Windows {
             Linux::KeyKp3 => Ok(Self::Keypad3PageDn),
             Linux::KeyKp0 => Ok(Self::Keypad0Insert),
             Linux::KeyKpDot => Ok(Self::KeypadDot),
-            Linux::KeyZenkakuhankaku => Ok(Self::KeyF24), // KeyLANG5
-            Linux::Key102nd => Ok(Self::KeyNonUSSlashBar), // TODO unsure
+            Linux::KeyZenkakuhankaku => Ok(Self::KeyLANG1), // TODO unsure
+            Linux::Key102nd => Ok(Self::KeyNonUSSlashBar),  // TODO unsure
             Linux::KeyF11 => Ok(Self::KeyF11),
             Linux::KeyF12 => Ok(Self::KeyF12),
-            Linux::KeyRo => Ok(Self::KeyInternational1),
-            Linux::KeyKatakana => Ok(Self::KeyLANG3),
-            Linux::KeyHiragana => Ok(Self::KeyLANG4),
-            Linux::KeyHenkan => Ok(Self::KeyInternational4),
-            Linux::KeyKatakanahiragana => Ok(Self::KeyInternational2),
-            Linux::KeyMuhenkan => Ok(Self::KeyInternational5),
+            Linux::KeyRo => Ok(Self::ErrorRollOver), // TODO unsure
+            Linux::KeyKatakana => Ok(Self::KeyLANG1), // TODO unsure
+            Linux::KeyHiragana => Ok(Self::KeyLANG2), // TODO unsure
+            Linux::KeyHenkan => Ok(Self::KeyLANG3),  // TODO unsure
+            Linux::KeyKatakanahiragana => Ok(Self::KeyLANG4), // TODO unsure
+            Linux::KeyMuhenkan => Ok(Self::KeyLANG4), // TODO unsure
             Linux::KeyKpJpComma => Ok(Self::KeypadComma),
             Linux::KeyKpEnter => Ok(Self::KeypadEnter),
             Linux::KeyRightCtrl => Ok(Self::KeyRightCtrl),
@@ -558,9 +555,9 @@ impl TryFrom<Linux> for Windows {
             Linux::KeyPause => Ok(Self::KeyPause),
             Linux::KeyScale => Err(()), // TODO
             Linux::KeyKpcomma => Ok(Self::KeypadComma),
-            Linux::KeyHanguel => Ok(Self::KeyLANG1), // FIXME should be 00F2?
-            Linux::KeyHanja => Ok(Self::KeyLANG2),   // FIXME should be 00F1?
-            Linux::KeyYen => Ok(Self::KeyInternational3),
+            Linux::KeyHangeul => Ok(Self::KeyInternational1), // TODO unsure
+            Linux::KeyHanja => Ok(Self::KeyInternational2),   // TODO unsure
+            Linux::KeyYen => Ok(Self::KeyInternational3),     // TODO unsure
             Linux::KeyLeftMeta => Ok(Self::KeyLeftGUI),
             Linux::KeyRightmeta => Ok(Self::KeyRightGUI),
             Linux::KeyCompose => Ok(Self::KeyApplication),
@@ -810,22 +807,21 @@ impl TryFrom<Windows> for Linux {
             Windows::KeyF23 => Ok(Self::KeyF23),
             Windows::KeyF24 => Ok(Self::KeyF24),
             Windows::KeypadComma => Ok(Self::KeyKpcomma),
-            Windows::KeyInternational1 => Ok(Self::KeyRo),
-            Windows::KeyInternational2 => Ok(Self::KeyKatakanahiragana),
+            Windows::KeyInternational1 => Ok(Self::KeyHangeul),
+            Windows::KeyInternational2 => Ok(Self::KeyHanja),
             Windows::KeyInternational3 => Ok(Self::KeyYen),
-            Windows::KeyInternational4 => Ok(Self::KeyHenkan),
-            Windows::KeyInternational5 => Ok(Self::KeyMuhenkan),
-            Windows::KeyLANG1 => Ok(Self::KeyHanguel),
-            Windows::KeyLANG2 => Ok(Self::KeyHanja),
-            Windows::KeyLANG3 => Ok(Self::KeyKatakana),
-            Windows::KeyLANG4 => Ok(Self::KeyHiragana),
+            Windows::KeyInternational4 => Err(()),
+            Windows::KeyInternational5 => Err(()),
+            Windows::KeyLANG1 => Ok(Self::KeyKatakana),
+            Windows::KeyLANG2 => Ok(Self::KeyHiragana),
+            Windows::KeyLANG3 => Ok(Self::KeyHenkan),
+            Windows::KeyLANG4 => Ok(Self::KeyKatakanahiragana),
             Windows::KeyLeftCtrl => Ok(Self::KeyLeftCtrl),
             Windows::KeyLeftShift => Ok(Self::KeyLeftShift),
             Windows::KeyLeftAlt => Ok(Self::KeyLeftAlt),
             Windows::KeyLeftGUI => Ok(Self::KeyLeftMeta),
             Windows::KeyRightCtrl => Ok(Self::KeyRightCtrl),
             Windows::KeyRightShift => Ok(Self::KeyRightShift),
-            Windows::KeyFakeRightShift => Ok(Self::KeyRightShift),
             Windows::KeyRightAlt => Ok(Self::KeyRightalt),
             Windows::KeyRightGUI => Ok(Self::KeyRightmeta),
             Windows::KeyScanNextTrack => Ok(Self::KeyNextsong),

src/server/frontend_task.rs

@@ -107,8 +107,7 @@ async fn handle_frontend_event(
     log::debug!("frontend: {event:?}");
     match event {
         FrontendRequest::Create => {
-            let handle = add_client(server, frontend).await;
-            resolve_dns(server, resolve_tx, handle).await;
+            add_client(server, frontend).await;
         }
         FrontendRequest::Activate(handle, active) => {
             if active {
@@ -141,12 +140,10 @@ async fn handle_frontend_event(
             return true;
         }
         FrontendRequest::UpdateFixIps(handle, fix_ips) => {
-            update_fix_ips(server, handle, fix_ips).await;
-            resolve_dns(server, resolve_tx, handle).await;
+            update_fix_ips(server, resolve_tx, handle, fix_ips).await;
         }
         FrontendRequest::UpdateHostname(handle, hostname) => {
             update_hostname(server, resolve_tx, handle, hostname).await;
-            resolve_dns(server, resolve_tx, handle).await;
         }
         FrontendRequest::UpdatePort(handle, port) => {
             update_port(server, handle, port).await;
@@ -155,41 +152,31 @@ async fn handle_frontend_event(
             update_pos(server, handle, capture, emulate, pos).await;
         }
         FrontendRequest::ResolveDns(handle) => {
-            resolve_dns(server, resolve_tx, handle).await;
+            let hostname = server
+                .client_manager
+                .borrow()
+                .get(handle)
+                .and_then(|(c, _)| c.hostname.clone());
+            if let Some(hostname) = hostname {
+                let _ = resolve_tx.send(DnsRequest { hostname, handle }).await;
+            }
         }
     };
     false
 }
 
-async fn resolve_dns(server: &Server, resolve_tx: &Sender<DnsRequest>, handle: ClientHandle) {
-    let hostname = server
-        .client_manager
-        .borrow()
-        .get(handle)
-        .and_then(|(c, _)| c.hostname.clone());
-    if let Some(hostname) = hostname {
-        let _ = resolve_tx
-            .send(DnsRequest {
-                hostname: hostname.clone(),
-                handle,
-            })
-            .await;
-    }
-}
-
 async fn broadcast(frontend: &mut FrontendListener, event: FrontendEvent) {
     if let Err(e) = frontend.broadcast_event(event).await {
         log::error!("error notifying frontend: {e}");
     }
 }
 
-pub async fn add_client(server: &Server, frontend: &mut FrontendListener) -> ClientHandle {
+pub async fn add_client(server: &Server, frontend: &mut FrontendListener) {
     let handle = server.client_manager.borrow_mut().add_client();
     log::info!("added client {handle}");
 
     let (c, s) = server.client_manager.borrow().get(handle).unwrap().clone();
     broadcast(frontend, FrontendEvent::Created(handle, c, s)).await;
-    handle
 }
 
 pub async fn deactivate_client(
@@ -264,13 +251,25 @@ pub async fn remove_client(
     }
 }
 
-async fn update_fix_ips(server: &Server, handle: ClientHandle, fix_ips: Vec<IpAddr>) {
-    let mut client_manager = server.client_manager.borrow_mut();
-    let Some((c, _)) = client_manager.get_mut(handle) else {
-        return;
+async fn update_fix_ips(
+    server: &Server,
+    resolve_tx: &Sender<DnsRequest>,
+    handle: ClientHandle,
+    fix_ips: Vec<IpAddr>,
+) {
+    let hostname = {
+        let mut client_manager = server.client_manager.borrow_mut();
+        let Some((c, _)) = client_manager.get_mut(handle) else {
+            return;
+        };
+
+        c.fix_ips = fix_ips;
+        c.hostname.clone()
     };
 
-    c.fix_ips = fix_ips;
+    if let Some(hostname) = hostname {
+        let _ = resolve_tx.send(DnsRequest { hostname, handle }).await;
+    }
 }
 
 async fn update_hostname(