mirror of https://github.com/rustdesk/rustdesk.git synced 2026-09-18 10:21:03 +03:00

Files

rustdesk be24391993 refactor(msi): pass the app name to the printer custom actions

preprocess.py rewrote the CustomActions sources per customer so the printer
carried the app name, which meant the dll was recompiled for every custom
client and, worse, left the app name baked into a compiled binary.

Pass it through CustomActionData instead. Only the printer and its port ever
varied: the INF path and the driver name ship under their stock names and
preprocess.py already forced the driver name back to RustDesk, so a single
build of the dll now serves every custom client.

Both actions treat the name as optional and fall back to the stock name, so a
package built before this still installs and uninstalls its printer.

This also unblocks patching a prebuilt msi template, which cannot work while a
compiled dll contains the app name: replacing a string inside a PE would shift
everything after it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q7fBdTwziR5BHTkSz7Tzcm

2026-08-05 20:47:38 +08:00

CustomActions

refactor(msi): pass the app name to the printer custom actions

2026-08-05 20:47:38 +08:00

Package

refactor(msi): pass the app name to the printer custom actions

2026-08-05 20:47:38 +08:00

.gitignore

fix: msi, app icon (#7830 )

2024-04-25 22:35:51 +08:00

msi.sln

Add Windows arm64 support (#15139 )

2026-06-18 22:37:15 +08:00

preprocess.py

refactor(msi): pass the app name to the printer custom actions

2026-08-05 20:47:38 +08:00

README.md

visual studio 2019 -> 2022

2024-04-20 18:20:09 +08:00

README.md

RustDesk msi project

Use Visual Studio 2022 to compile this project.

This project is mainly derived from https://github.com/MediaPortal/MediaPortal-2.git .

Steps

python preprocess.py, see python preprocess.py -h for help.
Build the .sln solution.

Run msiexec /i package.msi /l*v install.log to record the log.

Usage

Put the custom dialog bitmaps in "Resources" directory. The supported bitmaps are ['WixUIBannerBmp', 'WixUIDialogBmp', 'WixUIExclamationIco', 'WixUIInfoIco', 'WixUINewIco', 'WixUIUpIco'].

Knowledge

properties

wix-toolset-set-custom-action-run-only-on-uninstall

Property Name	Install	Uninstall	Change	Repair	Upgrade
Installed	False	True	True	True	True
REINSTALL	False	False	False	True	False
UPGRADINGPRODUCTCODE	False	False	False	False	True
REMOVE	False	True	False	False	True

TODOs

Start menu. Uninstall
custom options
Custom client.
1. firewall and tcp allow. Outgoing
2. Show license ?
3. Do create service. Outgoing.

README.md

RustDesk msi project

Steps

Usage

Knowledge

properties

TODOs

Refs