diff --git a/AGENTS.md b/AGENTS.md index a32b940ad..21e631f1d 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -73,6 +73,13 @@ * Do not extract or reshape existing code just to enable your new code; look for a mechanism that leaves existing lines untouched (e.g. hide/show an existing object instead of refactoring its construction into a helper for rebuilding). * Put new logic in self-contained functions in the module it belongs to (platform-specific logic in `src/platform/`, with `use` inside the function body to avoid churning shared import blocks). Call sites in shared files (`src/tray.rs`, `src/core_main.rs`, `src/server/connection.rs`, …) should be thin one-line hooks. +## Reviewing a PR + +* Review only what the diff introduces. Verify ownership with `gh pr diff` before reporting a finding — if the offending lines are untouched context, it is a pre-existing problem, not this PR's. +* List pre-existing problems in a separate section at the end, or leave out the ones that are not fatal. Never mix them into the findings the author has to fix. +* Before re-reviewing, read the author's reply comments. Do not re-raise items they declined on scope grounds. +* State a finding's consequence exactly: distinguish "the value is lost" from "the shortcut is inert but the value still saves". + ## Localization (`src/lang/*.rs`) Each file is a `HashMap`. Layout: