show login dialog when clicking note if not logged in (#13856)

Signed-off-by: 21pages <sunboeasy@gmail.com>

flutter/lib/common/widgets/toolbar.dart

@@ -6,10 +6,12 @@ import 'package:flutter/services.dart';
 import 'package:flutter_hbb/common.dart';
 import 'package:flutter_hbb/common/shared_state.dart';
 import 'package:flutter_hbb/common/widgets/dialog.dart';
+import 'package:flutter_hbb/common/widgets/login.dart';
 import 'package:flutter_hbb/consts.dart';
 import 'package:flutter_hbb/desktop/widgets/remote_toolbar.dart';
 import 'package:flutter_hbb/models/model.dart';
 import 'package:flutter_hbb/models/platform_model.dart';
+import 'package:flutter_hbb/utils/multi_window_manager.dart';
 import 'package:get/get.dart';
 
 bool isEditOsPassword = false;
@@ -193,14 +195,26 @@ List<TTextMenu> toolbarControls(BuildContext context, String id, FFI ffi) {
     );
   }
   // note
-  if (isDefaultConn &&
+  if (isDefaultConn && !bind.isDisableAccount()) {
-      bind
-          .sessionGetAuditServerSync(sessionId: sessionId, typ: "conn")
-          .isNotEmpty) {
     v.add(
       TTextMenu(
           child: Text(translate('Note')),
-          onPressed: () => showAuditDialog(ffi)),
+          onPressed: () async {
+            bool isLogin =
+                bind.mainGetLocalOption(key: 'access_token').isNotEmpty;
+            if (!isLogin) {
+              final res = await loginDialog();
+              if (res != true) return;
+              // Desktop: send message to main window to refresh login status
+              // Web: login is required before connection, so no need to refresh
+              // Mobile: same isolate, no need to send message
+              if (isDesktop) {
+                rustDeskWinManager.call(
+                    WindowType.Main, kWindowRefreshCurrentUser, "");
+              }
+            }
+            showAuditDialog(ffi);
+          }),
     );
   }
   // divider

flutter/lib/consts.dart

@@ -50,6 +50,7 @@ const String kAppTypeDesktopPortForward = "port forward";
 const String kAppTypeDesktopTerminal = "terminal";
 
 const String kWindowMainWindowOnTop = "main_window_on_top";
+const String kWindowRefreshCurrentUser = "refresh_current_user";
 const String kWindowGetWindowInfo = "get_window_info";
 const String kWindowGetScreenList = "get_screen_list";
 // This method is not used, maybe it can be removed.

flutter/lib/desktop/pages/desktop_home_page.dart

@@ -776,6 +776,8 @@ class _DesktopHomePageState extends State<DesktopHomePage>
       }
       if (call.method == kWindowMainWindowOnTop) {
         windowOnTop(null);
+      } else if (call.method == kWindowRefreshCurrentUser) {
+        gFFI.userModel.refreshCurrentUser();
       } else if (call.method == kWindowGetWindowInfo) {
         final screen = (await window_size.getWindowInfo()).screen;
         if (screen == null) {

flutter/lib/desktop/pages/desktop_setting_page.dart

@@ -561,19 +561,21 @@ class _GeneralState extends State<_General> {
       children.add(_OptionCheckBox(
           context, 'Allow linux headless', kOptionAllowLinuxHeadless));
     }
-    children.add(_OptionCheckBox(
+    if (!bind.isDisableAccount()) {
-      context,
+      children.add(_OptionCheckBox(
-      'note-at-conn-end-tip',
+        context,
-      kOptionAllowAskForNoteAtEndOfConnection,
+        'note-at-conn-end-tip',
-      isServer: false,
+        kOptionAllowAskForNoteAtEndOfConnection,
-      optSetter: (key, value) async {
+        isServer: false,
-        if (value && !gFFI.userModel.isLogin) {
+        optSetter: (key, value) async {
-          final res = await loginDialog();
+          if (value && !gFFI.userModel.isLogin) {
-          if (res != true) return;
+            final res = await loginDialog();
-        }
+            if (res != true) return;
-        await mainSetLocalBoolOption(key, value);
+          }
-      },
+          await mainSetLocalBoolOption(key, value);
-    ));
+        },
+      ));
+    }
     return _Card(title: 'Other', children: children);
   }
 

flutter/lib/mobile/pages/settings_page.dart

@@ -786,23 +786,24 @@ class _SettingsState extends State<SettingsPage> with WidgetsBindingObserver {
               showThemeSettings(gFFI.dialogManager);
             },
           ),
-          SettingsTile.switchTile(
+          if (!bind.isDisableAccount())
-            title: Text(translate('note-at-conn-end-tip')),
+            SettingsTile.switchTile(
-            initialValue: _allowAskForNoteAtEndOfConnection,
+              title: Text(translate('note-at-conn-end-tip')),
-            onToggle: (v) async {
+              initialValue: _allowAskForNoteAtEndOfConnection,
-              if (v && !gFFI.userModel.isLogin) {
+              onToggle: (v) async {
-                final res = await loginDialog();
+                if (v && !gFFI.userModel.isLogin) {
-                if (res != true) return;
+                  final res = await loginDialog();
-              }
+                  if (res != true) return;
-              await mainSetLocalBoolOption(
+                }
-                  kOptionAllowAskForNoteAtEndOfConnection, v);
+                await mainSetLocalBoolOption(
-              final newValue = mainGetLocalBoolOptionSync(
+                    kOptionAllowAskForNoteAtEndOfConnection, v);
-                  kOptionAllowAskForNoteAtEndOfConnection);
+                final newValue = mainGetLocalBoolOptionSync(
-              setState(() {
+                    kOptionAllowAskForNoteAtEndOfConnection);
-                _allowAskForNoteAtEndOfConnection = newValue;
+                setState(() {
-              });
+                  _allowAskForNoteAtEndOfConnection = newValue;
-            },
+                });
-          )
+              },
+            )
         ]),
         if (isAndroid)
           SettingsSection(title: Text(translate('Hardware Codec')), tiles: [

flutter/lib/models/model.dart

@@ -1101,6 +1101,9 @@ class FfiModel with ChangeNotifier {
 
   void _queryAuditGuid(String peerId) async {
     try {
+      if (bind.isDisableAccount()) {
+        return;
+      }
       if (bind
           .sessionGetAuditServerSync(sessionId: sessionId, typ: "conn/active")
           .isEmpty) {