Files
lan-mouse/lan-mouse-gtk/src/client_row.rs
Jon Kinney 72c86c0d83 feat: peer version exchange with soft-warn UI indicator
Adds a one-shot Hello message to the lan-mouse wire protocol so each
peer can display the other end's build commit hash and warn on
version mismatch. Soft-warn only — mismatched versions never refuse
traffic.

Wire change (lan-mouse-proto)
* `ProtoEvent::Hello { commit: [u8; 8] }` carries the 8-byte ASCII
  short commit from shadow_rs's `SHORT_COMMIT`. Encoded/decoded
  alongside the existing event variants.
* `EventType::Hello` is appended to the enum so existing IDs are
  untouched. Old peers receive the event, hit `InvalidEventId`, and
  silently skip it via the forward-compat handler in
  `connect.rs::receive_loop` — the connection is unaffected.

Daemon
* Connect side sends one Hello immediately after the DTLS handshake
  authenticates and before the ping_pong loop starts. Best-effort,
  fire-and-forget — `log::debug!` on send error.
* Listen side mirrors the peer's Hello with its own (same shape as
  the existing Ping → Pong reply), so the peer's connect-side
  receive_loop populates `ClientState::peer_commit` for that
  handle.
* The disconnect path clears `peer_commit` so a stale hash isn't
  shown after the connection drops.

IPC
* `ClientState::peer_commit: Option<[u8; 8]>`. `None` means the
  peer hasn't sent Hello yet — either fresh connection or older
  build that predates the event.

GTK
* `ClientObject` exposes `peer-commit` as an `Option<String>`
  property; `peer_commit_to_string` converts the wire `[u8; 8]` to
  the displayable hex.
* `lan_mouse_gtk::run` now takes the local commit and stashes it in
  a `OnceLock` so per-row UI can compare against each peer's hash.
* `ClientRow::refresh_version_status` re-renders the collapsed
  subtitle with Pango markup whenever the property changes:
   - matched → green   "peer version: <hex> · matched"
   - mismatch → orange "peer version: <hex> · ours: <hex>"
   - unknown → orange  "peer version: unknown · ours: <hex>"
* Window invokes `refresh_version_status` from
  `update_client_state` after writing the new property, and
  `bind` calls it once on row construction so the initial
  subtitle isn't blank.

Known limitation: state-change broadcasts from the network side
(set_alive / set_active_addr / set_peer_commit) don't currently
trigger a `FrontendEvent::State` directly; the UI picks up the
latest values on the next user-driven broadcast. Same pre-existing
behavior as the alive/active_addr fields.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-14 22:59:26 +02:00

190 lines
6.4 KiB
Rust

mod imp;
use adw::prelude::*;
use adw::subclass::prelude::*;
use gtk::glib::{self, Object};
use lan_mouse_ipc::{DEFAULT_PORT, Position};
use super::ClientObject;
glib::wrapper! {
pub struct ClientRow(ObjectSubclass<imp::ClientRow>)
@extends gtk::ListBoxRow, gtk::Widget, adw::PreferencesRow, adw::ExpanderRow,
@implements gtk::Accessible, gtk::Actionable, gtk::Buildable, gtk::ConstraintTarget;
}
impl ClientRow {
pub fn new(client_object: &ClientObject) -> Self {
let client_row: Self = Object::builder().build();
client_row
.imp()
.client_object
.borrow_mut()
.replace(client_object.clone());
client_row
}
pub fn bind(&self, client_object: &ClientObject) {
let mut bindings = self.imp().bindings.borrow_mut();
// bind client active to switch state
let active_binding = client_object
.bind_property("active", &self.imp().enable_switch.get(), "state")
.sync_create()
.build();
// bind client active to switch position
let switch_position_binding = client_object
.bind_property("active", &self.imp().enable_switch.get(), "active")
.sync_create()
.build();
// bind hostname to hostname edit field
let hostname_binding = client_object
.bind_property("hostname", &self.imp().hostname.get(), "text")
.transform_to(|_, v: Option<String>| {
if let Some(hostname) = v {
Some(hostname)
} else {
Some("".to_string())
}
})
.sync_create()
.build();
// bind hostname to title
let title_binding = client_object
.bind_property("hostname", self, "title")
.transform_to(|_, v: Option<String>| v.or(Some("<span font_style=\"italic\" font_weight=\"light\" foreground=\"darkgrey\">no hostname!</span>".to_string())))
.sync_create()
.build();
// bind port to port edit field
let port_binding = client_object
.bind_property("port", &self.imp().port.get(), "text")
.transform_to(|_, v: u32| {
if v == DEFAULT_PORT as u32 {
Some("".to_string())
} else {
Some(v.to_string())
}
})
.sync_create()
.build();
// bind port to subtitle
let subtitle_binding = client_object
.bind_property("port", self, "subtitle")
.sync_create()
.build();
// bind position to selected position
let position_binding = client_object
.bind_property("position", &self.imp().position.get(), "selected")
.transform_to(|_, v: String| match v.as_str() {
"right" => Some(1u32),
"top" => Some(2u32),
"bottom" => Some(3u32),
_ => Some(0u32),
})
.sync_create()
.build();
// bind resolving status to spinner visibility
let resolve_binding = client_object
.bind_property(
"resolving",
&self.imp().dns_loading_indicator.get(),
"spinning",
)
.sync_create()
.build();
// bind ips to tooltip-text
let ip_binding = client_object
.bind_property("ips", &self.imp().dns_button.get(), "tooltip-text")
.transform_to(|_, ips: Vec<String>| {
if ips.is_empty() {
Some("no ip addresses associated with this client".into())
} else {
Some(ips.join("\n"))
}
})
.sync_create()
.build();
bindings.push(active_binding);
bindings.push(switch_position_binding);
bindings.push(hostname_binding);
bindings.push(title_binding);
bindings.push(port_binding);
bindings.push(subtitle_binding);
bindings.push(position_binding);
bindings.push(resolve_binding);
bindings.push(ip_binding);
// Render the initial collapsed subtitle from whatever
// peer_commit the ClientObject was created with. Subsequent
// changes are pushed by `Window::update_client_state` calling
// `refresh_version_status` after writing the new property.
self.refresh_version_status();
}
pub fn unbind(&self) {
for binding in self.imp().bindings.borrow_mut().drain(..) {
binding.unbind();
}
}
pub fn set_active(&self, active: bool) {
self.imp().set_active(active);
}
pub fn set_hostname(&self, hostname: Option<String>) {
self.imp().set_hostname(hostname);
}
pub fn set_port(&self, port: u16) {
self.imp().set_port(port);
}
pub fn set_position(&self, pos: Position) {
self.imp().set_pos(pos);
}
pub fn set_dns_state(&self, resolved: bool) {
self.imp().set_dns_state(resolved);
}
/// Recompute the collapsed subtitle (Pango markup) based on the
/// current `peer-commit` property and the local build's commit.
/// Soft-warn semantics: a missing or mismatched peer commit
/// surfaces as orange text but never blocks traffic. Called by
/// the window after `update_client_state` writes the new
/// `peer-commit`. The dns-status icon is left to its existing
/// `set_dns_state` handler so the two indicators don't fight
/// for the same CSS class.
pub fn refresh_version_status(&self) {
let peer: Option<String> = self
.imp()
.client_object
.borrow()
.as_ref()
.and_then(|co| co.property::<Option<String>>("peer-commit"));
let local = crate::local_commit_str();
let markup = match peer.as_deref() {
None => format!(
r##"<span foreground="#ffaa33">peer version: unknown · ours: {local}</span>"##
),
Some(p) if p == local.as_str() => format!(
r##"<span foreground="#33cc66">peer version: {p} · matched</span>"##
),
Some(p) => format!(
r##"<span foreground="#ffaa33">peer version: {p} · ours: {local}</span>"##
),
};
self.set_subtitle(&markup);
}
}