move bounds check to display_util

.github/workflows/cachix.yml

@@ -7,7 +7,7 @@ jobs:
       matrix:
        os: 
         - ubuntu-latest
-        - macos-13
+        - macos-latest
         - macos-14
     name: "Build"
     runs-on: ${{ matrix.os }} 
@@ -31,7 +31,7 @@ jobs:
       run: nix build --print-build-logs --show-trace .#packages.x86_64-linux.lan-mouse
 
     - name: Build lan-mouse (x86_64-darwin)
-      if: matrix.os == 'macos-13'
+      if: matrix.os == 'macos-latest'
       run: nix build --print-build-logs --show-trace .#packages.x86_64-darwin.lan-mouse
 
     - name: Build lan-mouse (aarch64-darwin)

.github/workflows/pre-release.yml

@@ -78,7 +78,7 @@ jobs:
         path: lan-mouse-windows.zip
 
   macos-release-build:
-    runs-on: macos-13
+    runs-on: macos-latest
     steps:
     - uses: actions/checkout@v4
     - name: install dependencies

.github/workflows/rust.yml

@@ -92,7 +92,7 @@ jobs:
           target/debug/*.dll
 
   build-macos:
-    runs-on: macos-13
+    runs-on: macos-latest
     steps:
     - uses: actions/checkout@v4
     - name: install dependencies

.github/workflows/tagged-release.yml

@@ -74,7 +74,7 @@ jobs:
         path: lan-mouse-windows.zip
 
   macos-release-build:
-    runs-on: macos-13
+    runs-on: macos-latest
     steps:
     - uses: actions/checkout@v4
     - name: install dependencies

Cargo.lock

@@ -1284,7 +1284,7 @@ dependencies = [
 
 [[package]]
 name = "lan-mouse"
-version = "0.8.0"
+version = "0.7.3"
 dependencies = [
  "anyhow",
  "ashpd",

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "lan-mouse"
 description = "Software KVM Switch / mouse & keyboard sharing software for Local Area Networks"
-version = "0.8.0"
+version = "0.7.3"
 edition = "2021"
 license = "GPL-3.0-or-later"
 repository = "https://github.com/ferdinandschober/lan-mouse"
@@ -22,7 +22,7 @@ anyhow = "1.0.71"
 log = "0.4.20"
 env_logger = "0.11.3"
 serde_json = "1.0.107"
-tokio = {version = "1.32.0", features = ["io-util", "io-std", "macros", "net", "process", "rt", "sync", "signal"] }
+tokio = {version = "1.32.0", features = ["io-util", "io-std", "macros", "net", "rt", "sync", "signal"] }
 async-trait = "0.1.73"
 futures-core = "0.3.28"
 futures = "0.3.28"

src/capture/wayland.rs

@@ -111,7 +111,6 @@ struct State {
     qh: QueueHandle<Self>,
     pending_events: VecDeque<(ClientHandle, Event)>,
     output_info: Vec<(WlOutput, OutputInfo)>,
-    scroll_discrete_pending: bool,
 }
 
 struct Inner {
@@ -352,7 +351,6 @@ impl WaylandInputCapture {
             read_guard: None,
             pending_events: VecDeque::new(),
             output_info: vec![],
-            scroll_discrete_pending: false,
         };
 
         // dispatch registry to () again, in order to read all wl_outputs
@@ -754,12 +752,6 @@ impl Dispatch<WlPointer, ()> for State {
             }
             wl_pointer::Event::Axis { time, axis, value } => {
                 let (_, client) = app.focused.as_ref().unwrap();
-                if app.scroll_discrete_pending {
-                    // each axisvalue120 event is coupled with
-                    // a corresponding axis event, which needs to
-                    // be ignored to not duplicate the scrolling
-                    app.scroll_discrete_pending = false;
-                } else {
                 app.pending_events.push_back((
                     *client,
                     Event::Pointer(PointerEvent::Axis {
@@ -769,10 +761,8 @@ impl Dispatch<WlPointer, ()> for State {
                     }),
                 ));
             }
-            }
             wl_pointer::Event::AxisValue120 { axis, value120 } => {
                 let (_, client) = app.focused.as_ref().unwrap();
-                app.scroll_discrete_pending = true;
                 app.pending_events.push_back((
                     *client,
                     Event::Pointer(PointerEvent::AxisDiscrete120 {

src/capture/windows.rs

@@ -14,7 +14,7 @@ use std::task::ready;
 use std::{io, pin::Pin, thread};
 use tokio::sync::mpsc::{channel, Receiver, Sender};
 use windows::core::{w, PCWSTR};
-use windows::Win32::Foundation::{FALSE, HINSTANCE, HWND, LPARAM, LRESULT, RECT, WPARAM};
+use windows::Win32::Foundation::{FALSE, HINSTANCE, HWND, LPARAM, LRESULT, WPARAM};
 use windows::Win32::Graphics::Gdi::{
     EnumDisplayDevicesW, EnumDisplaySettingsW, DEVMODEW, DISPLAY_DEVICEW,
     DISPLAY_DEVICE_ATTACHED_TO_DESKTOP, ENUM_CURRENT_SETTINGS,
@@ -43,6 +43,7 @@ use crate::{
     event::Event,
     scancode,
 };
+use crate::display_util::{DirectedLine, Display, Point};
 
 pub struct WindowsInputCapture {
     event_rx: Receiver<(ClientHandle, Event)>,
@@ -93,7 +94,7 @@ unsafe fn get_event_tid() -> Option<u32> {
     }
 }
 
-static mut ENTRY_POINT: (i32, i32) = (0, 0);
+static mut ENTRY_POINT: Point<i32> = Point { x: 0, y: 0 };
 
 fn to_mouse_event(wparam: WPARAM, lparam: LPARAM) -> Option<PointerEvent> {
     let mouse_low_level: MSLLHOOKSTRUCT =
@@ -130,18 +131,17 @@ fn to_mouse_event(wparam: WPARAM, lparam: LPARAM) -> Option<PointerEvent> {
             state: 0,
         }),
         WPARAM(p) if p == WM_MOUSEMOVE as usize => unsafe {
-            let (x, y) = (mouse_low_level.pt.x, mouse_low_level.pt.y);
+            let current = Point { x: mouse_low_level.pt.x, y: mouse_low_level.pt.y };
-            let (ex, ey) = ENTRY_POINT;
+            let diff = current - ENTRY_POINT;
-            let (dx, dy) = (x - ex, y - ey);
             Some(PointerEvent::Motion {
                 time: 0,
-                relative_x: dx as f64,
+                relative_x: diff.x as f64,
-                relative_y: dy as f64,
+                relative_y: diff.y as f64,
             })
         },
         WPARAM(p) if p == WM_MOUSEWHEEL as usize => Some(PointerEvent::AxisDiscrete120 {
             axis: 0,
-            value: -(mouse_low_level.mouseData as i32 >> 16),
+            value: -(mouse_low_level.mouseData as i32),
         }),
         WPARAM(p) if p == WM_XBUTTONDOWN as usize || p == WM_XBUTTONUP as usize => {
             let hb = mouse_low_level.mouseData >> 16;
@@ -210,31 +210,6 @@ unsafe fn to_key_event(wparam: WPARAM, lparam: LPARAM) -> Option<KeyboardEvent>
     }
 }
 
-///
-/// clamp point to display bounds
-///
-/// # Arguments
-///
-/// * `prev_point`: coordinates, the cursor was before entering, within bounds of a display
-/// * `entry_point`: point to clamp
-///
-/// returns: (i32, i32), the corrected entry point
-///
-fn clamp_to_display_bounds(prev_point: (i32, i32), point: (i32, i32)) -> (i32, i32) {
-    /* find display where movement came from */
-    let display_regions = unsafe { get_display_regions() };
-    let display = display_regions
-        .iter()
-        .find(|&d| is_within_dp_region(prev_point, d))
-        .unwrap();
-
-    /* clamp to bounds (inclusive) */
-    let (x, y) = point;
-    let (min_x, max_x) = (display.left, display.right - 1);
-    let (min_y, max_y) = (display.top, display.bottom - 1);
-    (x.clamp(min_x, max_x), y.clamp(min_y, max_y))
-}
-
 unsafe fn send_blocking(event: Event) {
     if let Some(active) = ACTIVE_CLIENT {
         block_on(async move {
@@ -249,8 +224,9 @@ unsafe fn check_client_activation(wparam: WPARAM, lparam: LPARAM) -> bool {
     }
     let mouse_low_level: MSLLHOOKSTRUCT =
         unsafe { *std::mem::transmute::<LPARAM, *const MSLLHOOKSTRUCT>(lparam) };
-    static mut PREV_POS: Option<(i32, i32)> = None;
+    static mut PREV_POS: Option<Point<i32>> = None;
-    let curr_pos = (mouse_low_level.pt.x, mouse_low_level.pt.y);
+    let curr_pos = Point { x: mouse_low_level.pt.x, y: mouse_low_level.pt.y};
+    log::warn!("POSITION: {curr_pos:?} - display: {:?}", curr_pos.display_in_bounds(get_display_regions()));
     let prev_pos = PREV_POS.unwrap_or(curr_pos);
     PREV_POS.replace(curr_pos);
 
@@ -263,7 +239,8 @@ unsafe fn check_client_activation(wparam: WPARAM, lparam: LPARAM) -> bool {
     }
 
     /* check if a client was activated */
-    let Some(pos) = entered_barrier(prev_pos, curr_pos, get_display_regions()) else {
+    let line = DirectedLine { start: prev_pos, end: curr_pos };
+    let Some((display, pos)) = line.crossed_display_bounds(get_display_regions()) else {
         return ret;
     };
 
@@ -274,7 +251,7 @@ unsafe fn check_client_activation(wparam: WPARAM, lparam: LPARAM) -> bool {
 
     /* update active client and entry point */
     ACTIVE_CLIENT.replace(*client);
-    ENTRY_POINT = clamp_to_display_bounds(prev_pos, curr_pos);
+    ENTRY_POINT = curr_pos.clamp_to_display(&display);
 
     /* notify main thread */
     log::debug!("ENTERED @ {prev_pos:?} -> {curr_pos:?}");
@@ -347,7 +324,7 @@ unsafe extern "system" fn window_proc(
     LRESULT(1)
 }
 
-fn enumerate_displays() -> Vec<RECT> {
+fn enumerate_displays() -> Vec<Display<i32>> {
     unsafe {
         let mut display_rects = vec![];
         let mut devices = vec![];
@@ -379,11 +356,11 @@ fn enumerate_displays() -> Vec<RECT> {
             let (x, y) = (pos.x, pos.y);
             let (width, height) = (dev_mode.dmPelsWidth, dev_mode.dmPelsHeight);
 
-            display_rects.push(RECT {
+            display_rects.push(Display {
                 left: x,
-                right: x + width as i32,
+                right: x + width as i32 - 1,
                 top: y,
-                bottom: y + height as i32,
+                bottom: y + height as i32 - 1,
             });
         }
         display_rects
@@ -392,8 +369,8 @@ fn enumerate_displays() -> Vec<RECT> {
 
 static mut DISPLAY_RESOLUTION_CHANGED: bool = true;
 
-unsafe fn get_display_regions() -> &'static Vec<RECT> {
+unsafe fn get_display_regions() -> &'static Vec<Display<i32>> {
-    static mut DISPLAYS: Vec<RECT> = vec![];
+    static mut DISPLAYS: Vec<Display<i32>> = vec![];
     if DISPLAY_RESOLUTION_CHANGED {
         DISPLAYS = enumerate_displays();
         DISPLAY_RESOLUTION_CHANGED = false;
@@ -402,73 +379,6 @@ unsafe fn get_display_regions() -> &'static Vec<RECT> {
     &*addr_of!(DISPLAYS)
 }
 
-fn is_within_dp_region(point: (i32, i32), display: &RECT) -> bool {
-    [
-        Position::Left,
-        Position::Right,
-        Position::Top,
-        Position::Bottom,
-    ]
-    .iter()
-    .all(|&pos| is_within_dp_boundary(point, display, pos))
-}
-fn is_within_dp_boundary(point: (i32, i32), display: &RECT, pos: Position) -> bool {
-    let (x, y) = point;
-    match pos {
-        Position::Left => display.left <= x,
-        Position::Right => display.right > x,
-        Position::Top => display.top <= y,
-        Position::Bottom => display.bottom > y,
-    }
-}
-
-/// returns whether the given position is within the display bounds with respect to the given
-/// barrier position
-///
-/// # Arguments
-///
-/// * `x`:
-/// * `y`:
-/// * `displays`:
-/// * `pos`:
-///
-/// returns: bool
-///
-fn in_bounds(point: (i32, i32), displays: &[RECT], pos: Position) -> bool {
-    displays
-        .iter()
-        .any(|d| is_within_dp_boundary(point, d, pos))
-}
-
-fn in_display_region(point: (i32, i32), displays: &[RECT]) -> bool {
-    displays.iter().any(|d| is_within_dp_region(point, d))
-}
-
-fn moved_across_boundary(
-    prev_pos: (i32, i32),
-    curr_pos: (i32, i32),
-    displays: &[RECT],
-    pos: Position,
-) -> bool {
-    /* was within bounds, but is not anymore */
-    in_display_region(prev_pos, displays) && !in_bounds(curr_pos, displays, pos)
-}
-
-fn entered_barrier(
-    prev_pos: (i32, i32),
-    curr_pos: (i32, i32),
-    displays: &[RECT],
-) -> Option<Position> {
-    [
-        Position::Left,
-        Position::Right,
-        Position::Top,
-        Position::Bottom,
-    ]
-    .into_iter()
-    .find(|&pos| moved_across_boundary(prev_pos, curr_pos, displays, pos))
-}
-
 fn get_msg() -> Option<MSG> {
     unsafe {
         let mut msg = std::mem::zeroed();

src/client.rs

@@ -102,8 +102,6 @@ pub struct ClientConfig {
     pub port: u16,
     /// position of a client on screen
     pub pos: Position,
-    /// enter hook
-    pub cmd: Option<String>,
 }
 
 impl Default for ClientConfig {
@@ -113,7 +111,6 @@ impl Default for ClientConfig {
             hostname: Default::default(),
             fix_ips: Default::default(),
             pos: Default::default(),
-            cmd: None,
         }
     }
 }

src/config.rs

@@ -31,7 +31,6 @@ pub struct TomlClient {
     pub ips: Option<Vec<IpAddr>>,
     pub port: Option<u16>,
     pub activate_on_startup: Option<bool>,
-    pub enter_hook: Option<String>,
 }
 
 impl ConfigToml {
@@ -93,7 +92,6 @@ pub struct ConfigClient {
     pub port: u16,
     pub pos: Position,
     pub active: bool,
-    pub enter_hook: Option<String>,
 }
 
 const DEFAULT_RELEASE_KEYS: [scancode::Linux; 4] =
@@ -210,14 +208,12 @@ impl Config {
                     None => c.host_name.clone(),
                 };
                 let active = c.activate_on_startup.unwrap_or(false);
-                let enter_hook = c.enter_hook.clone();
                 ConfigClient {
                     ips,
                     hostname,
                     port,
                     pos: *pos,
                     active,
-                    enter_hook,
                 }
             })
             .collect()

src/display_util.rs

@@ -0,0 +1,114 @@
+use std::ops::{Add, Mul, Sub};
+use crate::client::Position;
+
+#[derive(Copy, Clone, Debug, Eq, PartialEq)]
+pub struct Point<T> {
+    pub x: T,
+    pub y: T,
+}
+
+impl<T: Sub<Output = T>> Sub for Point<T> {
+    type Output = Self;
+    fn sub(self, rhs: Self) -> Self::Output {
+        let x: T = self.x - rhs.x;
+        let y: T = self.y - rhs.y;
+        Self { x, y }
+    }
+}
+
+impl<T: Copy + Eq + Ord + Sub<Output = T> + Mul<Output = T> + Add<Output = T>> Point<T> {
+
+    pub fn display_in_bounds<'a>(&self, displays: &'a[Display<T>]) -> Option<&'a Display<T>> {
+        displays.iter().find(|&d| self.in_display_bounds(d))
+    }
+
+    pub fn in_display_bounds(&self, display: &Display<T>) -> bool {
+        self.clamp_to_display(display) == *self
+    }
+
+    pub fn clamp_to_display(&self, display: &Display<T>) -> Self {
+        let x = self.x.clamp(display.left, display.right);
+        let y = self.y.clamp(display.top, display.bottom);
+        Self { x, y }
+    }
+
+    /// Calculates the direction of maximum change between this point and the point given by other
+    ///
+    /// # Arguments
+    ///
+    /// * `other`: the point to calculate the distance
+    ///
+    /// returns: Position -> The direction in which the distance is largest
+    ///
+    /// # Examples
+    ///
+    /// ```
+    /// use lan_mouse::client::Position;
+    /// use lan_mouse::display_util::Point;
+    /// let a = Point { x: 0, y: 0 };
+    /// let b = Point { x: 1, y: 2 };
+    /// assert_eq!(a.direction_of_maximum_change(b), Position::Bottom)
+    /// ```
+    ///
+    /// ```
+    /// use lan_mouse::client::Position;
+    /// use lan_mouse::display_util::Point;
+    /// let a = Point { x: 0, y: 0 };
+    /// let b = Point { x: 1, y: -2 };
+    /// assert_eq!(a.direction_of_maximum_change(b), Position::Top)
+    /// ```
+    /// ```
+    /// use lan_mouse::client::Position;
+    /// use lan_mouse::display_util::Point;
+    /// let a = Point { x: 0, y: 0 };
+    /// let b = Point { x: -2, y: -1 };
+    /// assert_eq!(a.direction_of_maximum_change(b), Position::Left)
+    /// ```
+    /// ```
+    /// use lan_mouse::client::Position;
+    /// use lan_mouse::display_util::Point;
+    /// let a = Point { x: 0, y: 0 };
+    /// let b = Point { x: 2, y: -1 };
+    /// assert_eq!(a.direction_of_maximum_change(b), Position::Right)
+    /// ```
+    pub fn direction_of_maximum_change(self, other: Self) -> Position {
+        let distances = [
+            (Position::Left, self.x - other.x),
+            (Position::Right, other.x - self.x),
+            (Position::Top, self.y - other.y),
+            (Position::Bottom, other.y - self.y),
+        ];
+        distances.into_iter().max_by_key(|(_, d)| *d).map(|(p, _)| p).expect("no position")
+    }
+}
+
+#[derive(Copy, Clone, Debug, Eq, PartialEq)]
+pub struct Display<T> {
+    pub left: T,
+    pub right: T,
+    pub top: T,
+    pub bottom: T,
+}
+
+#[derive(Clone, Copy)]
+pub struct DirectedLine<T> {
+    pub start: Point<T>,
+    pub end: Point<T>,
+}
+
+impl<T: Copy + Eq + Ord + Sub<Output = T> + Mul<Output = T> + Add<Output = T>> DirectedLine<T> {
+    pub fn crossed_display_bounds<'a>(&self, displays: &'a [Display<T>]) -> Option<(&'a Display<T>, Position)> {
+        // was in bounds
+        let Some(display) = self.start.display_in_bounds(displays) else {
+            return None;
+        };
+        // still in bounds
+        if self.end.display_in_bounds(displays).is_some() {
+            return None;
+        }
+        // was in bounds of `display`, now out of bounds
+        let clamped = self.end.clamp_to_display(&display);
+        let dir = clamped.direction_of_maximum_change(self.end);
+        Some((display, dir))
+    }
+}

src/emulate/wlroots.rs

@@ -182,8 +182,7 @@ impl VirtualInput {
                     }
                     PointerEvent::AxisDiscrete120 { axis, value } => {
                         let axis: Axis = (axis as u32).try_into()?;
-                        self.pointer
+                        self.pointer.axis(0, axis, (value / 15) as f64);
-                            .axis_discrete(0, axis, value as f64 / 6., value / 120);
                         self.pointer.frame();
                     }
                     PointerEvent::Frame {} => self.pointer.frame(),

src/frontend.rs

@@ -107,18 +107,16 @@ pub enum FrontendRequest {
     UpdatePosition(ClientHandle, Position),
     /// update fix-ips
     UpdateFixIps(ClientHandle, Vec<IpAddr>),
-    /// request the state of the given client
-    GetState(ClientHandle),
 }
 
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub enum FrontendEvent {
     /// a client was created
     Created(ClientHandle, ClientConfig, ClientState),
-    /// no such client
+    /// a client was updated
-    NoSuchClient(ClientHandle),
+    Updated(ClientHandle, ClientConfig),
     /// state changed
-    State(ClientHandle, ClientConfig, ClientState),
+    StateChange(ClientHandle, ClientState),
     /// the client was deleted
     Deleted(ClientHandle),
     /// new port, reason of failure (if failed)
@@ -237,7 +235,9 @@ impl FrontendListener {
         let json = serde_json::to_string(&notify).unwrap();
         let payload = json.as_bytes();
         let len = payload.len().to_be_bytes();
-        log::debug!("broadcasting event to streams: {json}");
+        log::debug!("json: {json}, len: {}", payload.len());
+
+        log::debug!("broadcasting event to streams: {:?}", self.tx_streams);
         let mut keep = vec![];
         // TODO do simultaneously
         for tx in self.tx_streams.iter_mut() {

src/frontend/cli.rs

@@ -100,18 +100,6 @@ impl<'a> Cli<'a> {
         }
     }
 
-    async fn update_client(&mut self, handle: ClientHandle) -> Result<()> {
-        self.send_request(FrontendRequest::GetState(handle)).await?;
-        loop {
-            let event = self.await_event().await?;
-            self.handle_event(event.clone());
-            if let FrontendEvent::State(_, _, _) | FrontendEvent::NoSuchClient(_) = event {
-                break;
-            }
-        }
-        Ok(())
-    }
-
     async fn execute(&mut self, cmd: Command) -> Result<()> {
         match cmd {
             Command::None => {}
@@ -137,8 +125,14 @@ impl<'a> Cli<'a> {
                     FrontendRequest::UpdatePosition(handle, pos),
                 ] {
                     self.send_request(request).await?;
+                    loop {
+                        let event = self.await_event().await?;
+                        self.handle_event(event.clone());
+                        if let FrontendEvent::Updated(_, _) = event {
+                            break;
+                        }
+                    }
                 }
-                self.update_client(handle).await?;
             }
             Command::Disconnect(id) => {
                 self.send_request(FrontendRequest::Delete(id)).await?;
@@ -154,12 +148,26 @@ impl<'a> Cli<'a> {
             Command::Activate(id) => {
                 self.send_request(FrontendRequest::Activate(id, true))
                     .await?;
-                self.update_client(id).await?;
+                loop {
+                    let event = self.await_event().await?;
+                    self.handle_event(event.clone());
+                    if let FrontendEvent::StateChange(_, _) = event {
+                        self.handle_event(event);
+                        break;
+                    }
+                }
             }
             Command::Deactivate(id) => {
                 self.send_request(FrontendRequest::Activate(id, false))
                     .await?;
-                self.update_client(id).await?;
+                loop {
+                    let event = self.await_event().await?;
+                    self.handle_event(event.clone());
+                    if let FrontendEvent::StateChange(_, _) = event {
+                        self.handle_event(event);
+                        break;
+                    }
+                }
             }
             Command::List => {
                 self.send_request(FrontendRequest::Enumerate()).await?;
@@ -174,12 +182,25 @@ impl<'a> Cli<'a> {
             Command::SetHost(handle, host) => {
                 let request = FrontendRequest::UpdateHostname(handle, Some(host.clone()));
                 self.send_request(request).await?;
-                self.update_client(handle).await?;
+                loop {
+                    let event = self.await_event().await?;
+                    self.handle_event(event.clone());
+                    if let FrontendEvent::Updated(_, _) = event {
+                        self.handle_event(event);
+                        break;
+                    }
+                }
             }
             Command::SetPort(handle, port) => {
                 let request = FrontendRequest::UpdatePort(handle, port.unwrap_or(DEFAULT_PORT));
                 self.send_request(request).await?;
-                self.update_client(handle).await?;
+                loop {
+                    let event = self.await_event().await?;
+                    self.handle_event(event.clone());
+                    if let FrontendEvent::Updated(_, _) = event {
+                        break;
+                    }
+                }
             }
             Command::Help => {
                 for cmd_type in [
@@ -223,11 +244,8 @@ impl<'a> Cli<'a> {
                 eprintln!();
                 self.clients.push((h, c, s));
             }
-            FrontendEvent::NoSuchClient(h) => {
+            FrontendEvent::Updated(h, c) => {
-                eprintln!("no such client: {h}");
+                if let Some((_, config, _)) = self.find_mut(h) {
-            }
-            FrontendEvent::State(h, c, s) => {
-                if let Some((_, config, state)) = self.find_mut(h) {
                     let old_host = config.hostname.clone().unwrap_or("\"\"".into());
                     let new_host = c.hostname.clone().unwrap_or("\"\"".into());
                     if old_host != new_host {
@@ -243,6 +261,10 @@ impl<'a> Cli<'a> {
                         eprintln!("client {h} ips updated: {:?}", c.fix_ips)
                     }
                     *config = c;
+                }
+            }
+            FrontendEvent::StateChange(h, s) => {
+                if let Some((_, _, state)) = self.find_mut(h) {
                     if state.active ^ s.active {
                         eprintln!(
                             "client {h} {}",

src/frontend/gtk.rs

@@ -126,11 +126,12 @@ fn build_ui(app: &Application) {
                 FrontendEvent::Deleted(client) => {
                     window.delete_client(client);
                 }
-                FrontendEvent::State(handle, config, state) => {
+                FrontendEvent::Updated(handle, client) => {
-                    window.update_client_config(handle, config);
+                    window.update_client_config(handle, client);
+                }
+                FrontendEvent::StateChange(handle, state) => {
                     window.update_client_state(handle, state);
                 }
-                FrontendEvent::NoSuchClient(_) => { }
                 FrontendEvent::Error(e) => {
                     window.show_toast(e.as_str());
                 },

src/frontend/gtk/window.rs

@@ -51,10 +51,6 @@ impl Window {
             .expect("Could not get clients")
     }
 
-    fn client_by_idx(&self, idx: u32) -> Option<ClientObject> {
-        self.clients().item(idx).map(|o| o.downcast().unwrap())
-    }
-
     fn setup_clients(&self) {
         let model = gio::ListStore::new::<ClientObject>();
         self.imp().clients.replace(Some(model));
@@ -66,24 +62,27 @@ impl Window {
                 let client_object = obj.downcast_ref().expect("Expected object of type `ClientObject`.");
                 let row = window.create_client_row(client_object);
                 row.connect_closure("request-update", false, closure_local!(@strong window => move |row: ClientRow, active: bool| {
-                    if let Some(client) = window.client_by_idx(row.index() as u32) {
+                    let index = row.index() as u32;
-                        window.request_client_activate(&client, active);
+                    let Some(client) = window.clients().item(index) else {
-                        window.request_client_update(&client);
+                        return;
-                        window.request_client_state(&client);
+                    };
-                    }
+                    let client = client.downcast_ref::<ClientObject>().unwrap();
+                    window.request_client_update(client);
+                    window.request_client_activate(client, active)
                 }));
                 row.connect_closure("request-delete", false, closure_local!(@strong window => move |row: ClientRow| {
-                    if let Some(client) = window.client_by_idx(row.index() as u32) {
+                    let index = row.index() as u32;
-                        window.request_client_delete(&client);
+                    window.request_client_delete(index);
-                    }
                 }));
                 row.connect_closure("request-dns", false, closure_local!(@strong window => move
                 |row: ClientRow| {
-                    if let Some(client) = window.client_by_idx(row.index() as u32) {
+                    let index = row.index() as u32;
-                        window.request_client_update(&client);
+                    let Some(client) = window.clients().item(index) else {
-                        window.request_dns(&client);
+                        return;
-                        window.request_client_state(&client);
+                    };
-                    }
+                    let client = client.downcast_ref::<ClientObject>().unwrap();
+                    window.request_client_update(client);
+                    window.request_dns(index);
                 }));
                 row.upcast()
             })
@@ -178,7 +177,7 @@ impl Window {
 
         if state.resolving != data.resolving {
             client_object.set_resolving(state.resolving);
-            log::debug!("resolving {}: {}", data.handle, state.resolving);
+            log::debug!("resolving {}: {}", data.handle, state.active);
         }
 
         self.update_dns_state(handle, !state.ips.is_empty());
@@ -205,6 +204,20 @@ impl Window {
         }
     }
 
+    pub fn request_dns(&self, idx: u32) {
+        let client_object = self.clients().item(idx).unwrap();
+        let client_object: &ClientObject = client_object.downcast_ref().unwrap();
+        let data = client_object.get_data();
+        let event = FrontendRequest::ResolveDns(data.handle);
+        self.request(event);
+    }
+
+    pub fn request_client_create(&self) {
+        let event = FrontendRequest::Create;
+        self.imp().set_port(DEFAULT_PORT);
+        self.request(event);
+    }
+
     pub fn request_port_change(&self) {
         let port = self.imp().port_entry.get().text().to_string();
         if let Ok(port) = port.as_str().parse::<u16>() {
@@ -214,23 +227,6 @@ impl Window {
         }
     }
 
-    pub fn request_client_state(&self, client: &ClientObject) {
-        let handle = client.handle();
-        let event = FrontendRequest::GetState(handle);
-        self.request(event);
-    }
-
-    pub fn request_client_create(&self) {
-        let event = FrontendRequest::Create;
-        self.request(event);
-    }
-
-    pub fn request_dns(&self, client: &ClientObject) {
-        let data = client.get_data();
-        let event = FrontendRequest::ResolveDns(data.handle);
-        self.request(event);
-    }
-
     pub fn request_client_update(&self, client: &ClientObject) {
         let handle = client.handle();
         let data = client.get_data();
@@ -243,25 +239,33 @@ impl Window {
             FrontendRequest::UpdatePosition(handle, position),
             FrontendRequest::UpdatePort(handle, port),
         ] {
+            log::debug!("requesting: {event:?}");
             self.request(event);
         }
     }
 
     pub fn request_client_activate(&self, client: &ClientObject, active: bool) {
         let handle = client.handle();
+
         let event = FrontendRequest::Activate(handle, active);
+        log::debug!("requesting: {event:?}");
         self.request(event);
     }
 
-    pub fn request_client_delete(&self, client: &ClientObject) {
+    pub fn request_client_delete(&self, idx: u32) {
-        let handle = client.handle();
+        if let Some(obj) = self.clients().item(idx) {
+            let client_object: &ClientObject = obj
+                .downcast_ref()
+                .expect("Expected object of type `ClientObject`.");
+            let handle = client_object.handle();
             let event = FrontendRequest::Delete(handle);
             self.request(event);
         }
+    }
 
     pub fn request(&self, event: FrontendRequest) {
         let json = serde_json::to_string(&event).unwrap();
-        log::debug!("requesting: {json}");
+        log::debug!("requesting {json}");
         let mut stream = self.imp().stream.borrow_mut();
         let stream = stream.as_mut().unwrap();
         let bytes = json.as_bytes();

src/lib.rs

@@ -11,3 +11,4 @@ pub mod capture_test;
 pub mod emulation_test;
 pub mod frontend;
 pub mod scancode;
+pub mod display_util;

src/scancode.rs

@@ -3,8 +3,6 @@ use serde::{Deserialize, Serialize};
 
 /*
  * https://learn.microsoft.com/en-us/windows/win32/inputdev/about-keyboard-input
- * https://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf
- * https://kbd-project.org/docs/scancodes/scancodes-1.html
  */
 #[repr(u32)]
 #[derive(Debug, Clone, Copy, TryFromPrimitive)]
@@ -122,15 +120,15 @@ pub enum Windows {
     KeyF21 = 0x006C,
     KeyF22 = 0x006D,
     KeyF23 = 0x006E,
-    KeyF24 = 0x0076, // KeyLANG5
+    KeyF24 = 0x0076,
     KeypadComma = 0x007E,
     KeyInternational1 = 0x0073,
     KeyInternational2 = 0x0070,
-    KeyInternational3 = 0x007D, // typo in doc -> its Int'l 3 not Int'l 2
+    KeyInternational3 = 0x007D,
     #[allow(dead_code)]
-    KeyInternational4 = 0x0079,
+    KeyInternational4 = 0x0079, // FIXME unused
     #[allow(dead_code)]
-    KeyInternational5 = 0x007B,
+    KeyInternational5 = 0x007B, // FIXME unused
     // KeyInternational6 = 0x005C,
     KeyLANG1 = 0x0072,
     KeyLANG2 = 0x0071,
@@ -143,7 +141,6 @@ pub enum Windows {
     KeyLeftGUI = 0xE05B,
     KeyRightCtrl = 0xE01D,
     KeyRightShift = 0x0036,
-    KeyFakeRightShift = 0xE036,
     KeyRightAlt = 0xE038,
     KeyRightGUI = 0xE05C,
     KeyScanNextTrack = 0xE019,
@@ -296,7 +293,7 @@ pub enum Linux {
     KeyPause = 119,
     KeyScale = 120, /* AL Compiz Scale (Expose) */
     KeyKpcomma = 121,
-    KeyHanguel = 122,
+    KeyHangeul = 122,
     // KEY_HANGUEL = KeyHangeul,
     KeyHanja = 123,
     KeyYen = 124,
@@ -521,16 +518,16 @@ impl TryFrom<Linux> for Windows {
             Linux::KeyKp3 => Ok(Self::Keypad3PageDn),
             Linux::KeyKp0 => Ok(Self::Keypad0Insert),
             Linux::KeyKpDot => Ok(Self::KeypadDot),
-            Linux::KeyZenkakuhankaku => Ok(Self::KeyF24), // KeyLANG5
+            Linux::KeyZenkakuhankaku => Ok(Self::KeyLANG1), // TODO unsure
             Linux::Key102nd => Ok(Self::KeyNonUSSlashBar),  // TODO unsure
             Linux::KeyF11 => Ok(Self::KeyF11),
             Linux::KeyF12 => Ok(Self::KeyF12),
-            Linux::KeyRo => Ok(Self::KeyInternational1),
+            Linux::KeyRo => Ok(Self::ErrorRollOver), // TODO unsure
-            Linux::KeyKatakana => Ok(Self::KeyLANG3),
+            Linux::KeyKatakana => Ok(Self::KeyLANG1), // TODO unsure
-            Linux::KeyHiragana => Ok(Self::KeyLANG4),
+            Linux::KeyHiragana => Ok(Self::KeyLANG2), // TODO unsure
-            Linux::KeyHenkan => Ok(Self::KeyInternational4),
+            Linux::KeyHenkan => Ok(Self::KeyLANG3),  // TODO unsure
-            Linux::KeyKatakanahiragana => Ok(Self::KeyInternational2),
+            Linux::KeyKatakanahiragana => Ok(Self::KeyLANG4), // TODO unsure
-            Linux::KeyMuhenkan => Ok(Self::KeyInternational5),
+            Linux::KeyMuhenkan => Ok(Self::KeyLANG4), // TODO unsure
             Linux::KeyKpJpComma => Ok(Self::KeypadComma),
             Linux::KeyKpEnter => Ok(Self::KeypadEnter),
             Linux::KeyRightCtrl => Ok(Self::KeyRightCtrl),
@@ -558,9 +555,9 @@ impl TryFrom<Linux> for Windows {
             Linux::KeyPause => Ok(Self::KeyPause),
             Linux::KeyScale => Err(()), // TODO
             Linux::KeyKpcomma => Ok(Self::KeypadComma),
-            Linux::KeyHanguel => Ok(Self::KeyLANG1), // FIXME should be 00F2?
+            Linux::KeyHangeul => Ok(Self::KeyInternational1), // TODO unsure
-            Linux::KeyHanja => Ok(Self::KeyLANG2),   // FIXME should be 00F1?
+            Linux::KeyHanja => Ok(Self::KeyInternational2),   // TODO unsure
-            Linux::KeyYen => Ok(Self::KeyInternational3),
+            Linux::KeyYen => Ok(Self::KeyInternational3),     // TODO unsure
             Linux::KeyLeftMeta => Ok(Self::KeyLeftGUI),
             Linux::KeyRightmeta => Ok(Self::KeyRightGUI),
             Linux::KeyCompose => Ok(Self::KeyApplication),
@@ -810,22 +807,21 @@ impl TryFrom<Windows> for Linux {
             Windows::KeyF23 => Ok(Self::KeyF23),
             Windows::KeyF24 => Ok(Self::KeyF24),
             Windows::KeypadComma => Ok(Self::KeyKpcomma),
-            Windows::KeyInternational1 => Ok(Self::KeyRo),
+            Windows::KeyInternational1 => Ok(Self::KeyHangeul),
-            Windows::KeyInternational2 => Ok(Self::KeyKatakanahiragana),
+            Windows::KeyInternational2 => Ok(Self::KeyHanja),
             Windows::KeyInternational3 => Ok(Self::KeyYen),
-            Windows::KeyInternational4 => Ok(Self::KeyHenkan),
+            Windows::KeyInternational4 => Err(()),
-            Windows::KeyInternational5 => Ok(Self::KeyMuhenkan),
+            Windows::KeyInternational5 => Err(()),
-            Windows::KeyLANG1 => Ok(Self::KeyHanguel),
+            Windows::KeyLANG1 => Ok(Self::KeyKatakana),
-            Windows::KeyLANG2 => Ok(Self::KeyHanja),
+            Windows::KeyLANG2 => Ok(Self::KeyHiragana),
-            Windows::KeyLANG3 => Ok(Self::KeyKatakana),
+            Windows::KeyLANG3 => Ok(Self::KeyHenkan),
-            Windows::KeyLANG4 => Ok(Self::KeyHiragana),
+            Windows::KeyLANG4 => Ok(Self::KeyKatakanahiragana),
             Windows::KeyLeftCtrl => Ok(Self::KeyLeftCtrl),
             Windows::KeyLeftShift => Ok(Self::KeyLeftShift),
             Windows::KeyLeftAlt => Ok(Self::KeyLeftAlt),
             Windows::KeyLeftGUI => Ok(Self::KeyLeftMeta),
             Windows::KeyRightCtrl => Ok(Self::KeyRightCtrl),
             Windows::KeyRightShift => Ok(Self::KeyRightShift),
-            Windows::KeyFakeRightShift => Ok(Self::KeyRightShift),
             Windows::KeyRightAlt => Ok(Self::KeyRightalt),
             Windows::KeyRightGUI => Ok(Self::KeyRightmeta),
             Windows::KeyScanNextTrack => Ok(Self::KeyNextsong),

src/server.rs

@@ -55,7 +55,6 @@ impl Server {
                 fix_ips: config_client.ips.into_iter().collect(),
                 port: config_client.port,
                 pos: config_client.pos,
-                cmd: config_client.enter_hook,
             };
             let state = ClientState {
                 active: config_client.active,

src/server/capture_task.rs

@@ -2,7 +2,7 @@ use anyhow::{anyhow, Result};
 use futures::StreamExt;
 use std::{collections::HashSet, net::SocketAddr};
 
-use tokio::{process::Command, sync::mpsc::Sender, task::JoinHandle};
+use tokio::{sync::mpsc::Sender, task::JoinHandle};
 
 use crate::{
     capture::{self, InputCapture},
@@ -140,9 +140,6 @@ async fn handle_capture_event(
     if start_timer {
         let _ = timer_tx.try_send(());
     }
-    if enter {
-        spawn_hook_command(server, handle);
-    }
     if let Some(addr) = addr {
         if enter {
             let _ = sender_tx.send((Event::Enter(), addr)).await;
@@ -151,34 +148,3 @@ async fn handle_capture_event(
     }
     Ok(())
 }
-
-fn spawn_hook_command(server: &Server, handle: ClientHandle) {
-    let Some(cmd) = server
-        .client_manager
-        .borrow()
-        .get(handle)
-        .and_then(|(c, _)| c.cmd.clone())
-    else {
-        return;
-    };
-    tokio::task::spawn_local(async move {
-        log::info!("spawning command!");
-        let mut child = match Command::new("sh").arg("-c").arg(cmd.as_str()).spawn() {
-            Ok(c) => c,
-            Err(e) => {
-                log::warn!("could not execute cmd: {e}");
-                return;
-            }
-        };
-        match child.wait().await {
-            Ok(s) => {
-                if s.success() {
-                    log::info!("{cmd} exited successfully");
-                } else {
-                    log::warn!("{cmd} exited with {s}");
-                }
-            }
-            Err(e) => log::warn!("{cmd}: {e}"),
-        }
-    });
-}

src/server/frontend_task.rs

@@ -107,22 +107,20 @@ async fn handle_frontend_event(
     log::debug!("frontend: {event:?}");
     match event {
         FrontendRequest::Create => {
-            let handle = add_client(server, frontend).await;
+            add_client(server, frontend).await;
-            resolve_dns(server, resolve_tx, handle).await;
         }
         FrontendRequest::Activate(handle, active) => {
             if active {
-                activate_client(server, capture, emulate, handle).await;
+                activate_client(server, frontend, capture, emulate, handle).await;
             } else {
-                deactivate_client(server, capture, emulate, handle).await;
+                deactivate_client(server, frontend, capture, emulate, handle).await;
             }
         }
         FrontendRequest::ChangePort(port) => {
             let _ = port_tx.send(port).await;
         }
         FrontendRequest::Delete(handle) => {
-            remove_client(server, capture, emulate, handle).await;
+            remove_client(server, frontend, capture, emulate, handle).await;
-            broadcast(frontend, FrontendEvent::Deleted(handle)).await;
         }
         FrontendRequest::Enumerate() => {
             let clients = server
@@ -133,48 +131,38 @@ async fn handle_frontend_event(
                 .collect();
             broadcast(frontend, FrontendEvent::Enumerate(clients)).await;
         }
-        FrontendRequest::GetState(handle) => {
-            broadcast_client(server, frontend, handle).await;
-        }
         FrontendRequest::Terminate() => {
             log::info!("terminating gracefully...");
             return true;
         }
         FrontendRequest::UpdateFixIps(handle, fix_ips) => {
-            update_fix_ips(server, handle, fix_ips).await;
+            update_fix_ips(server, resolve_tx, handle, fix_ips).await;
-            resolve_dns(server, resolve_tx, handle).await;
+            broadcast_client_update(server, frontend, handle).await;
         }
         FrontendRequest::UpdateHostname(handle, hostname) => {
             update_hostname(server, resolve_tx, handle, hostname).await;
-            resolve_dns(server, resolve_tx, handle).await;
+            broadcast_client_update(server, frontend, handle).await;
         }
         FrontendRequest::UpdatePort(handle, port) => {
             update_port(server, handle, port).await;
+            broadcast_client_update(server, frontend, handle).await;
         }
         FrontendRequest::UpdatePosition(handle, pos) => {
             update_pos(server, handle, capture, emulate, pos).await;
+            broadcast_client_update(server, frontend, handle).await;
         }
         FrontendRequest::ResolveDns(handle) => {
-            resolve_dns(server, resolve_tx, handle).await;
-        }
-    };
-    false
-}
-
-async fn resolve_dns(server: &Server, resolve_tx: &Sender<DnsRequest>, handle: ClientHandle) {
             let hostname = server
                 .client_manager
                 .borrow()
                 .get(handle)
                 .and_then(|(c, _)| c.hostname.clone());
             if let Some(hostname) = hostname {
-        let _ = resolve_tx
+                let _ = resolve_tx.send(DnsRequest { hostname, handle }).await;
-            .send(DnsRequest {
-                hostname: hostname.clone(),
-                handle,
-            })
-            .await;
             }
+        }
+    };
+    false
 }
 
 async fn broadcast(frontend: &mut FrontendListener, event: FrontendEvent) {
@@ -183,24 +171,25 @@ async fn broadcast(frontend: &mut FrontendListener, event: FrontendEvent) {
     }
 }
 
-pub async fn add_client(server: &Server, frontend: &mut FrontendListener) -> ClientHandle {
+pub async fn add_client(server: &Server, frontend: &mut FrontendListener) {
     let handle = server.client_manager.borrow_mut().add_client();
     log::info!("added client {handle}");
 
     let (c, s) = server.client_manager.borrow().get(handle).unwrap().clone();
     broadcast(frontend, FrontendEvent::Created(handle, c, s)).await;
-    handle
 }
 
 pub async fn deactivate_client(
     server: &Server,
+    frontend: &mut FrontendListener,
     capture: &Sender<CaptureEvent>,
     emulate: &Sender<EmulationEvent>,
     handle: ClientHandle,
 ) {
-    match server.client_manager.borrow_mut().get_mut(handle) {
+    let state = match server.client_manager.borrow_mut().get_mut(handle) {
         Some((_, s)) => {
             s.active = false;
+            s.clone()
         }
         None => return,
     };
@@ -208,10 +197,13 @@ pub async fn deactivate_client(
     let event = ClientEvent::Destroy(handle);
     let _ = capture.send(CaptureEvent::ClientEvent(event)).await;
     let _ = emulate.send(EmulationEvent::ClientEvent(event)).await;
+    let event = FrontendEvent::StateChange(handle, state);
+    broadcast(frontend, event).await;
 }
 
 pub async fn activate_client(
     server: &Server,
+    frontend: &mut FrontendListener,
     capture: &Sender<CaptureEvent>,
     emulate: &Sender<EmulationEvent>,
     handle: ClientHandle,
@@ -225,13 +217,14 @@ pub async fn activate_client(
     let other = server.client_manager.borrow_mut().find_client(pos);
     if let Some(other) = other {
         if other != handle {
-            deactivate_client(server, capture, emulate, other).await;
+            deactivate_client(server, frontend, capture, emulate, other).await;
         }
     }
 
     /* activate the client */
-    if let Some((_, s)) = server.client_manager.borrow_mut().get_mut(handle) {
+    let state = if let Some((_, s)) = server.client_manager.borrow_mut().get_mut(handle) {
         s.active = true;
+        s.clone()
     } else {
         return;
     };
@@ -240,10 +233,13 @@ pub async fn activate_client(
     let event = ClientEvent::Create(handle, pos);
     let _ = capture.send(CaptureEvent::ClientEvent(event)).await;
     let _ = emulate.send(EmulationEvent::ClientEvent(event)).await;
+    let event = FrontendEvent::StateChange(handle, state);
+    broadcast(frontend, event).await;
 }
 
 pub async fn remove_client(
     server: &Server,
+    frontend: &mut FrontendListener,
     capture: &Sender<CaptureEvent>,
     emulate: &Sender<EmulationEvent>,
     handle: ClientHandle,
@@ -262,15 +258,30 @@ pub async fn remove_client(
         let _ = capture.send(CaptureEvent::ClientEvent(destroy)).await;
         let _ = emulate.send(EmulationEvent::ClientEvent(destroy)).await;
     }
+
+    let event = FrontendEvent::Deleted(handle);
+    broadcast(frontend, event).await;
 }
 
-async fn update_fix_ips(server: &Server, handle: ClientHandle, fix_ips: Vec<IpAddr>) {
+async fn update_fix_ips(
+    server: &Server,
+    resolve_tx: &Sender<DnsRequest>,
+    handle: ClientHandle,
+    fix_ips: Vec<IpAddr>,
+) {
+    let hostname = {
         let mut client_manager = server.client_manager.borrow_mut();
         let Some((c, _)) = client_manager.get_mut(handle) else {
             return;
         };
 
         c.fix_ips = fix_ips;
+        c.hostname.clone()
+    };
+
+    if let Some(hostname) = hostname {
+        let _ = resolve_tx.send(DnsRequest { hostname, handle }).await;
+    }
 }
 
 async fn update_hostname(
@@ -345,11 +356,11 @@ async fn update_pos(
     }
 }
 
-async fn broadcast_client(server: &Server, frontend: &mut FrontendListener, handle: ClientHandle) {
+async fn broadcast_client_update(
-    let client = server.client_manager.borrow().get(handle).cloned();
+    server: &Server,
-    if let Some((config, state)) = client {
+    frontend: &mut FrontendListener,
-        broadcast(frontend, FrontendEvent::State(handle, config, state)).await;
+    handle: ClientHandle,
-    } else {
+) {
-        broadcast(frontend, FrontendEvent::NoSuchClient(handle)).await;
+    let (client, _) = server.client_manager.borrow().get(handle).unwrap().clone();
-    }
+    broadcast(frontend, FrontendEvent::Updated(handle, client)).await;
 }

src/server/resolver_task.rs

@@ -35,7 +35,7 @@ pub fn new(
                 Ok(ips) => ips,
                 Err(e) => {
                     log::warn!("could not resolve host '{host}': {e}");
-                    vec![]
+                    continue;
                 }
             };
 
@@ -59,10 +59,14 @@ async fn notify_state_change(
     server: &mut Server,
     handle: ClientHandle,
 ) {
-    let state = server.client_manager.borrow_mut().get_mut(handle).cloned();
+    let state = server
-    if let Some((config, state)) = state {
+        .client_manager
+        .borrow_mut()
+        .get_mut(handle)
+        .map(|(_, s)| s.clone());
+    if let Some(state) = state {
         let _ = frontend
-            .send(FrontendEvent::State(handle, config, state))
+            .send(FrontendEvent::StateChange(handle, state))
             .await;
     }
 }