Compare commits

..

10 Commits

Author SHA1 Message Date
Ferdinand Schober
1bec5915e6 update cachix and disable magic nix-cache
magic nix cache seems to hang forever.
2026-02-20 15:47:43 +01:00
Peter Hutterer
ad63b6ba20 Handle the RemoteDesktop portal restore token correctly (#383)
For a session to actually persist, we need to request a persistence mode
which we already do. The portal then returns a restore-token (in the
form of an uuid) to us as part of the response to Start.

This token must then be passed into the *next* session during
SelectDevices to restore the previous session.

The token is officially a single-use token, so we need to overwrite it
every time. In practise the current XDP implementation may re-use the
token but we cannot rely on that.

Reading and writing the token is not async since we expect them to be
uuid-length.

Closes #74.
2026-02-11 13:27:32 +01:00
Ferdinand Schober
e80625648e build releases on ubuntu 22.04 (#382) 2026-02-10 07:29:45 +01:00
Ferdinand Schober
96c63374d0 rust.yml: run fmt/build/check/test separately (#375) 2026-02-08 16:54:42 +01:00
Ferdinand Schober
b8fdbb35ac fix: build failure in lan-mouse-ipc standalone 2026-02-08 14:22:46 +01:00
Ferdinand Schober
5d5f4bbe6f fix: build failure in input-capture standalone 2026-02-08 14:19:47 +01:00
Ferdinand Schober
8e96025f12 clear config, when unable to parse 2026-02-08 13:27:38 +01:00
Ferdinand Schober
f01459b2a8 fix crash when config file does not exist 2026-02-08 13:23:29 +01:00
Ferdinand Schober
394c018e11 ad fixme for memory leak 2026-02-08 13:14:11 +01:00
Ferdinand Schober
648b2b58a4 Save config (#345)
* add setters for clients and authorized keys

* impl change config request

* basic saving functionality

* save config automatically

* add TODO comment
2026-02-07 18:36:07 +01:00
9 changed files with 180 additions and 181 deletions

View File

@@ -1,40 +1,46 @@
name: Binary Cache name: Nix Binary Cache
on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
workflow_dispatch:
on: [push, pull_request, workflow_dispatch]
jobs: jobs:
nix: nix:
strategy: strategy:
matrix: matrix:
os: os:
- ubuntu-latest - ubuntu-latest
- macos-15-intel - macos-15-intel
- macos-14 - macos-latest
name: "Build" name: "Build"
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@v4 uses: actions/checkout@v4
with: with:
submodules: recursive submodules: recursive
- uses: DeterminateSystems/nix-installer-action@main # - uses: DeterminateSystems/nix-installer-action@main
with: # with:
logger: pretty # logger: pretty
- uses: DeterminateSystems/magic-nix-cache-action@main # - uses: DeterminateSystems/magic-nix-cache-action@main
- uses: cachix/cachix-action@v14 - uses: cachix/install-nix-action@v31
with: - uses: cachix/cachix-action@v16
name: lan-mouse with:
authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' name: lan-mouse
authToken: "${{ secrets.CACHIX_AUTH_TOKEN }}"
- name: Build lan-mouse (x86_64-linux) - name: Build lan-mouse (x86_64-linux)
if: matrix.os == 'ubuntu-latest' if: matrix.os == 'ubuntu-latest'
run: nix build --print-build-logs --show-trace .#packages.x86_64-linux.lan-mouse run: nix build --print-build-logs --show-trace .#packages.x86_64-linux.lan-mouse
- name: Build lan-mouse (x86_64-darwin) - name: Build lan-mouse (x86_64-darwin)
if: matrix.os == 'macos-15-intel' if: matrix.os == 'macos-15-intel'
run: nix build --print-build-logs --show-trace .#packages.x86_64-darwin.lan-mouse run: nix build --print-build-logs --show-trace .#packages.x86_64-darwin.lan-mouse
- name: Build lan-mouse (aarch64-darwin)
if: matrix.os == 'macos-14'
run: nix build --print-build-logs --show-trace .#packages.aarch64-darwin.lan-mouse
- name: Build lan-mouse (aarch64-darwin)
if: matrix.os == 'macos-latest'
run: nix build --print-build-logs --show-trace .#packages.aarch64-darwin.lan-mouse

View File

@@ -11,7 +11,7 @@ env:
jobs: jobs:
linux-release-build: linux-release-build:
runs-on: ubuntu-latest runs-on: ubuntu-22.04
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- name: install dependencies - name: install dependencies

View File

@@ -10,149 +10,87 @@ env:
CARGO_TERM_COLOR: always CARGO_TERM_COLOR: always
jobs: jobs:
build-linux: fmt:
name: Formatting
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- name: install dependencies - name: cargo fmt
run: | run: cargo fmt --check
sudo apt-get update
sudo apt-get install libx11-dev libxtst-dev
sudo apt-get install libadwaita-1-dev libgtk-4-dev
- name: Build
run: cargo build --verbose
- name: Run tests
run: cargo test --verbose
- name: Check Formatting
run: cargo fmt --check
- name: Clippy
run: cargo clippy --all-features --all-targets -- --deny warnings
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
name: lan-mouse
path: target/debug/lan-mouse
build-windows:
runs-on: windows-latest
ci:
name: ${{ matrix.job }} ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
- windows-latest
- macos-latest
- macos-15-intel
job:
- build
- check
- clippy
- test
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: actions/setup-python@v5 - uses: Swatinem/rust-cache@v2
with: - name: Install Linux deps
python-version: '3.11' if: runner.os == 'Linux'
# needed for cache restore run: |
- name: create gtk dir sudo apt-get update
run: mkdir C:\gtk-build\gtk\x64\release sudo apt-get install libx11-dev libxtst-dev libadwaita-1-dev libgtk-4-dev
- uses: actions/cache@v3 - name: Install macOS dependencies
id: cache if: runner.os == 'macOS'
with: run: brew install gtk4 libadwaita imagemagick
path: c:/gtk-build/gtk/x64/release/** - name: Install Windows Dependencies - create gtk dir
key: gtk-windows-build if: runner.os == 'Windows'
restore-keys: gtk-windows-build run: mkdir C:\gtk-build\gtk\x64\release
- name: Update path - name: Install Windows Dependencies - install gtk from cache
run: | uses: actions/cache@v3
echo "PKG_CONFIG=C:\gtk-build\gtk\x64\release\bin\pkgconf.exe" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append if: runner.os == 'Windows'
echo "C:\pkg-config-lite-0.28-1\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append id: cache
echo "C:\gtk-build\gtk\x64\release\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append with:
echo $env:GITHUB_PATH path: c:/gtk-build/gtk/x64/release/**
echo $env:PATH key: gtk-windows-build
- name: Install dependencies restore-keys: gtk-windows-build
if: steps.cache.outputs.cache-hit != 'true' - name: Install Windows Dependencies - update PATH
run: | if: runner.os == 'Windows'
# choco install msys2 run: |
# choco install visualstudio2022-workload-vctools echo "PKG_CONFIG=C:\gtk-build\gtk\x64\release\bin\pkgconf.exe" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
# choco install pkgconfiglite echo "C:\pkg-config-lite-0.28-1\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
py -m venv .venv echo "C:\gtk-build\gtk\x64\release\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
.venv\Scripts\activate.ps1 echo $env:GITHUB_PATH
py -m pip install gvsbuild echo $env:PATH
# see https://github.com/wingtk/gvsbuild/pull/1004 - name: Install Windows dependencies - build gtk
Move-Item "C:\Program Files\Git\usr\bin" "C:\Program Files\Git\usr\notbin" if: runner.os == 'Windows' && steps.cache.outputs.cache-hit != 'true'
Move-Item "C:\Program Files\Git\bin" "C:\Program Files\Git\notbin" run: |
gvsbuild build --msys-dir=C:\msys64 gtk4 libadwaita librsvg # choco install msys2
Move-Item "C:\Program Files\Git\usr\notbin" "C:\Program Files\Git\usr\bin" # choco install visualstudio2022-workload-vctools
Move-Item "C:\Program Files\Git\notbin" "C:\Program Files\Git\bin" # choco install pkgconfiglite
- name: Build py -m venv .venv
run: cargo build --verbose .venv\Scripts\activate.ps1
- name: Run tests py -m pip install gvsbuild
run: cargo test --verbose gvsbuild build --msys-dir=C:\msys64 gtk4 libadwaita librsvg
- name: Check Formatting - name: cargo build
run: cargo fmt --check if: matrix.job == 'build'
- name: Clippy run: cargo check --workspace --all-targets --all-features
run: cargo clippy --all-features --all-targets -- --deny warnings
- name: Copy Gtk Dlls
run: Get-Childitem -Path "C:\\gtk-build\\gtk\\x64\\release\\bin\\*.dll" -File -Recurse | Copy-Item -Destination "target\\debug"
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
name: lan-mouse-windows
path: |
target/debug/lan-mouse.exe
target/debug/*.dll
build-macos: - name: cargo check
runs-on: macos-15-intel if: matrix.job == 'check'
steps: run: cargo check --workspace --all-targets --all-features
- uses: actions/checkout@v4
- name: install dependencies
run: brew install gtk4 libadwaita imagemagick
- name: Build
run: cargo build --verbose
- name: Run tests
run: cargo test --verbose
- name: Check Formatting
run: cargo fmt --check
- name: Clippy
run: cargo clippy --all-features --all-targets -- --deny warnings
- name: Make icns
run: scripts/makeicns.sh
- name: Install cargo bundle
run: cargo install cargo-bundle
- name: Bundle
run: |
cargo bundle
scripts/copy-macos-dylib.sh
- name: Zip bundle
run: |
cd target/debug/bundle/osx
zip -r "Lan Mouse macOS (Intel).zip" "Lan Mouse.app"
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
name: Lan Mouse macOS (Intel)
path: target/debug/bundle/osx/Lan Mouse macOS (Intel).zip
build-macos-aarch64: - name: cargo test
runs-on: macos-14 if: matrix.job == 'test'
steps: run: cargo test --workspace --all-features
- uses: actions/checkout@v4
- name: install dependencies - name: cargo clippy
run: brew install gtk4 libadwaita imagemagick if: matrix.job == 'clippy'
- name: Build run: cargo clippy --workspace --all-targets --all-features -- -D warnings
run: cargo build --verbose
- name: Run tests - uses: clechasseur/rs-clippy-check@v4
run: cargo test --verbose if: matrix.job == 'clippy'
- name: Check Formatting with:
run: cargo fmt --check args: --workspace --all-targets --all-features
- name: Clippy
run: cargo clippy --all-features --all-targets -- --deny warnings
- name: Make icns
run: scripts/makeicns.sh
- name: Install cargo bundle
run: cargo install cargo-bundle
- name: Bundle
run: |
cargo bundle
scripts/copy-macos-dylib.sh
- name: Zip bundle
run: |
cd target/debug/bundle/osx
zip -r "Lan Mouse macOS (ARM).zip" "Lan Mouse.app"
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
name: Lan Mouse macOS (ARM)
path: target/debug/bundle/osx/Lan Mouse macOS (ARM).zip

View File

@@ -7,7 +7,7 @@ on:
jobs: jobs:
linux-release-build: linux-release-build:
runs-on: ubuntu-latest runs-on: ubuntu-22.04
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- name: install dependencies - name: install dependencies

View File

@@ -23,6 +23,7 @@ tokio = { version = "1.32.0", features = [
"rt", "rt",
"sync", "sync",
"signal", "signal",
"time",
] } ] }
once_cell = "1.19.0" once_cell = "1.19.0"
async-trait = "0.1.81" async-trait = "0.1.81"

View File

@@ -646,6 +646,7 @@ unsafe fn configure_cf_settings() -> Result<(), MacosCaptureCreationError> {
let event_source = CGEventSource::new(CGEventSourceStateID::CombinedSessionState) let event_source = CGEventSource::new(CGEventSourceStateID::CombinedSessionState)
.map_err(|_| MacosCaptureCreationError::EventSourceCreation)?; .map_err(|_| MacosCaptureCreationError::EventSourceCreation)?;
CGEventSourceSetLocalEventsSuppressionInterval(event_source, 0.05); CGEventSourceSetLocalEventsSuppressionInterval(event_source, 0.05);
// FIXME Memory Leak
// This is a private settings that allows the cursor to be hidden while in the background. // This is a private settings that allows the cursor to be hidden while in the background.
// It is used by Barrier and other apps. // It is used by Barrier and other apps.

View File

@@ -1,7 +1,8 @@
use futures::{StreamExt, future}; use futures::{StreamExt, future};
use std::{ use std::{
io, env, fs, io,
os::{fd::OwnedFd, unix::net::UnixStream}, os::{fd::OwnedFd, unix::net::UnixStream},
path::PathBuf,
sync::{ sync::{
Arc, Mutex, RwLock, Arc, Mutex, RwLock,
atomic::{AtomicBool, Ordering}, atomic::{AtomicBool, Ordering},
@@ -50,10 +51,45 @@ pub(crate) struct LibeiEmulation<'a> {
session: Session<'a, RemoteDesktop<'a>>, session: Session<'a, RemoteDesktop<'a>>,
} }
/// Get the path to the RemoteDesktop token file
fn get_token_file_path() -> PathBuf {
let cache_dir = env::var("XDG_CACHE_HOME")
.ok()
.map(PathBuf::from)
.unwrap_or_else(|| {
let home = env::var("HOME").expect("HOME not set");
PathBuf::from(home).join(".cache")
});
cache_dir.join("lan-mouse").join("remote-desktop.token")
}
/// Read the RemoteDesktop token from file
fn read_token() -> Option<String> {
let token_path = get_token_file_path();
match fs::read_to_string(&token_path) {
Ok(token) => Some(token.trim().to_string()),
Err(_) => None,
}
}
/// Write the RemoteDesktop token to file
fn write_token(token: &str) -> io::Result<()> {
let token_path = get_token_file_path();
if let Some(parent) = token_path.parent() {
fs::create_dir_all(parent)?;
}
fs::write(&token_path, token)?;
Ok(())
}
async fn get_ei_fd<'a>() async fn get_ei_fd<'a>()
-> Result<(RemoteDesktop<'a>, Session<'a, RemoteDesktop<'a>>, OwnedFd), ashpd::Error> { -> Result<(RemoteDesktop<'a>, Session<'a, RemoteDesktop<'a>>, OwnedFd), ashpd::Error> {
let remote_desktop = RemoteDesktop::new().await?; let remote_desktop = RemoteDesktop::new().await?;
let restore_token = read_token();
log::debug!("creating session ..."); log::debug!("creating session ...");
let session = remote_desktop.create_session().await?; let session = remote_desktop.create_session().await?;
@@ -62,13 +98,20 @@ async fn get_ei_fd<'a>()
.select_devices( .select_devices(
&session, &session,
DeviceType::Keyboard | DeviceType::Pointer, DeviceType::Keyboard | DeviceType::Pointer,
None, restore_token.as_deref(),
PersistMode::ExplicitlyRevoked, PersistMode::ExplicitlyRevoked,
) )
.await?; .await?;
log::info!("requesting permission for input emulation"); log::info!("requesting permission for input emulation");
let _devices = remote_desktop.start(&session, None).await?.response()?; let start_response = remote_desktop.start(&session, None).await?.response()?;
// The restore token is only valid once, we need to re-save it each time
if let Some(token_str) = start_response.restore_token() {
if let Err(e) = write_token(token_str) {
log::warn!("failed to save RemoteDesktop token: {}", e);
}
}
let fd = remote_desktop.connect_to_eis(&session).await?; let fd = remote_desktop.connect_to_eis(&session).await?;
Ok((remote_desktop, session, fd)) Ok((remote_desktop, session, fd))

View File

@@ -12,5 +12,5 @@ log = "0.4.22"
serde = { version = "1.0", features = ["derive"] } serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0.107" serde_json = "1.0.107"
thiserror = "2.0.0" thiserror = "2.0.0"
tokio = { version = "1.32.0", features = ["net", "io-util", "time"] } tokio = { version = "1.32.0", features = ["macros", "net", "io-util", "time"] }
tokio-stream = { version = "0.1.15", features = ["io-util"] } tokio-stream = { version = "0.1.15", features = ["io-util"] }

View File

@@ -5,7 +5,8 @@ use serde::{Deserialize, Serialize};
use std::collections::HashMap; use std::collections::HashMap;
use std::env::{self, VarError}; use std::env::{self, VarError};
use std::fmt::Display; use std::fmt::Display;
use std::fs; use std::fs::{self, File};
use std::io::Write;
use std::net::IpAddr; use std::net::IpAddr;
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
use std::{collections::HashSet, io}; use std::{collections::HashSet, io};
@@ -419,7 +420,7 @@ impl Config {
return; return;
} }
if self.config_toml.is_none() { if self.config_toml.is_none() {
self.config_toml = Default::default(); self.config_toml = Some(Default::default());
} }
self.config_toml.as_mut().expect("config").clients = self.config_toml.as_mut().expect("config").clients =
Some(clients.into_iter().map(|c| c.into()).collect::<Vec<_>>()); Some(clients.into_iter().map(|c| c.into()).collect::<Vec<_>>());
@@ -442,10 +443,15 @@ impl Config {
pub fn write_back(&self) -> Result<(), io::Error> { pub fn write_back(&self) -> Result<(), io::Error> {
log::info!("writing config to {:?}", &self.config_path); log::info!("writing config to {:?}", &self.config_path);
/* load the current configuration file */ /* load the current configuration file */
let current_config = fs::read_to_string(&self.config_path)?; let current_config = match fs::read_to_string(&self.config_path) {
let current_config = current_config.parse::<DocumentMut>().expect("fix me"); Ok(c) => c.parse::<DocumentMut>().unwrap_or_default(),
Err(e) => {
log::info!("{:?} {e} => creating new config", self.config_path());
Default::default()
}
};
let _current_config = let _current_config =
toml_edit::de::from_document::<ConfigToml>(current_config).expect("fixme"); toml_edit::de::from_document::<ConfigToml>(current_config).unwrap_or_default();
/* the new config */ /* the new config */
let new_config = self.config_toml.clone().unwrap_or_default(); let new_config = self.config_toml.clone().unwrap_or_default();
@@ -461,7 +467,11 @@ impl Config {
*/ */
/* write new config to file */ /* write new config to file */
fs::write(&self.config_path, new_config)?; if let Some(p) = self.config_path().parent() {
fs::create_dir_all(p)?;
}
let mut f = File::create(self.config_path())?;
f.write_all(new_config.as_bytes())?;
Ok(()) Ok(())
} }