From 9d674c51ca62e8f03ffcc4e34ab347dd08dcd754 Mon Sep 17 00:00:00 2001 From: Tzahi12345 Date: Mon, 27 Nov 2023 00:45:22 -0500 Subject: [PATCH] Fixed youtube-dl test --- backend/test/tests.js | 7 ++++--- backend/youtube-dl.js | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/backend/test/tests.js b/backend/test/tests.js index d2ad7a5..a80d054 100644 --- a/backend/test/tests.js +++ b/backend/test/tests.js @@ -631,10 +631,11 @@ describe('youtube-dl', async function() { await youtubedl_api.checkForYoutubeDLUpdate(); }); it('Check latest version', async function() { - const latest_version = await youtubedl_api.checkForYoutubeDLUpdate(); + const original_fork = config_api.getConfigItem('ytdl_default_downloader'); + const latest_version = await youtubedl_api.getLatestUpdateVersion(original_fork); const default_details_bin = fs.readJSONSync(CONSTS.DETAILS_BIN_PATH); - assert(default_details_bin['version'] === CONSTS.OUTDATED_YOUTUBEDL_VERSION); - assert(latest_version > default_details_bin['version']); + assert(default_details_bin[original_fork]['version'] === CONSTS.OUTDATED_YOUTUBEDL_VERSION); + assert(latest_version > default_details_bin[original_fork]['version']); }); it('Update youtube-dl', async function() { diff --git a/backend/youtube-dl.js b/backend/youtube-dl.js index a999628..e771bdf 100644 --- a/backend/youtube-dl.js +++ b/backend/youtube-dl.js @@ -96,7 +96,7 @@ exports.checkForYoutubeDLUpdate = async () => { const current_version = current_app_details['version']; const current_fork = current_app_details['downloader']; - const latest_version = await getLatestUpdateVersion(selected_fork); + const latest_version = await exports.getLatestUpdateVersion(selected_fork); // if the binary does not exist, or default_downloader doesn't match existing fork, or if the fork has been updated, redownload // TODO: don't redownload if fork already exists if (!fs.existsSync(output_file_path) || current_fork !== selected_fork || !current_version || current_version !== latest_version) { @@ -124,7 +124,7 @@ async function downloadLatestYoutubeDLBinaryGeneric(youtubedl_fork, new_version, updateDetailsJSON(new_version, youtubedl_fork, output_path); } -const getLatestUpdateVersion = async (youtubedl_fork) => { +exports.getLatestUpdateVersion = async (youtubedl_fork) => { const tags_url = exports.youtubedl_forks[youtubedl_fork]['tags_url']; return new Promise(resolve => { fetch(tags_url, {method: 'Get'})