From 378025bd9d02ee70fcd4c3f49ba732fff887d948 Mon Sep 17 00:00:00 2001 From: Tzahi12345 Date: Wed, 3 Jun 2020 20:56:48 -0400 Subject: [PATCH 1/2] Updated dockerfile to support Windows builds --- backend/Dockerfile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/backend/Dockerfile b/backend/Dockerfile index 6d337a4..ee6be52 100644 --- a/backend/Dockerfile +++ b/backend/Dockerfile @@ -16,10 +16,14 @@ RUN apk add --no-cache \ # switch to default user to not chown node_modules on startup USER $USER WORKDIR /app - COPY --chown=$UID:$GID [ "package.json", "package-lock.json", "/app/" ] + +# run npm install as root, required for Windows hosts +USER root RUN npm install +RUN chown -R $UID:$GID ./ + COPY --chown=$UID:$GID [ "./", "/app/" ] EXPOSE 17442 From e8ee4ffb64e84e590699546909c269c2a08896d1 Mon Sep 17 00:00:00 2001 From: Tzahi12345 Date: Sat, 6 Jun 2020 13:07:50 -0400 Subject: [PATCH 2/2] Made additional cleanups as per recs by SuperSandro --- backend/Dockerfile | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/backend/Dockerfile b/backend/Dockerfile index ee6be52..645b877 100644 --- a/backend/Dockerfile +++ b/backend/Dockerfile @@ -3,6 +3,7 @@ FROM alpine:3.12 ENV UID=1000 \ GID=1000 \ USER=youtube + RUN addgroup -S $USER -g $GID && adduser -D -S $USER -G $USER -u $UID RUN apk add --no-cache \ @@ -13,21 +14,14 @@ RUN apk add --no-cache \ && apk add --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing/ \ atomicparsley -# switch to default user to not chown node_modules on startup -USER $USER WORKDIR /app COPY --chown=$UID:$GID [ "package.json", "package-lock.json", "/app/" ] -# run npm install as root, required for Windows hosts -USER root -RUN npm install - -RUN chown -R $UID:$GID ./ +RUN npm install && chown -R $UID:$GID ./ COPY --chown=$UID:$GID [ "./", "/app/" ] EXPOSE 17442 -# switch back to root to allow UID/GID changing -USER root + ENTRYPOINT [ "/app/entrypoint.sh" ] CMD [ "node", "app.js" ]