From bd6f95feb1158d8e7494dd4821b9020e3ba7ec8f Mon Sep 17 00:00:00 2001 From: Johnny Silverman Date: Tue, 4 Nov 2025 02:56:48 +0200 Subject: [PATCH] Use const values for precision to improve code readability --- src/mainwindow.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp index 6cea9fc..9f81f36 100644 --- a/src/mainwindow.cpp +++ b/src/mainwindow.cpp @@ -13,6 +13,9 @@ #include #include +const int PRECISION_TOTALS_TO_STR = 2; +const int PRECISION_CAPACITY_TO_STR = 0; + MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent) , ui(new Ui::MainWindow) @@ -252,7 +255,7 @@ void MainWindow::updateUI(const QString ¤tDeviceName) double diskCapacityMB = localObj.value("user_capacity").toObject().value("bytes").toDouble() / 1e6; int64_t diskCapacityMbI64 = static_cast(diskCapacityMB); bool useGB = ui->actionUse_GB_instead_of_TB->isChecked(); - QString diskCapacityString = getMbToPrettyString(diskCapacityMbI64, 0, useGB); + QString diskCapacityString = getMbToPrettyString(diskCapacityMbI64, PRECISION_CAPACITY_TO_STR, useGB); QJsonObject temperatureObj = localObj["temperature"].toObject(); int temperatureInt = temperatureObj["current"].toInt(); @@ -446,7 +449,7 @@ void MainWindow::populateWindow(const QJsonObject &localObj, const QString &heal int64_t totalMbReadsI64 = 0; bool useGB = ui->actionUse_GB_instead_of_TB->isChecked(); - QString diskCapacityString = getMbToPrettyString(diskCapacityMbI64, 0, useGB); + QString diskCapacityString = getMbToPrettyString(diskCapacityMbI64, PRECISION_CAPACITY_TO_STR, useGB); QString totalReads; QString totalWrites; @@ -685,8 +688,8 @@ void MainWindow::populateWindow(const QJsonObject &localObj, const QString &heal } } - totalReads = getMbToPrettyString(totalMbReadsI64, 1, useGB); - totalWrites = getMbToPrettyString(totalMbWritesI64, 1, useGB); + totalReads = getMbToPrettyString(totalMbReadsI64, PRECISION_TOTALS_TO_STR, useGB); + totalWrites = getMbToPrettyString(totalMbWritesI64, PRECISION_TOTALS_TO_STR, useGB); totalReadsLineEdit->setText(totalReads); totalReadsLineEdit->setAlignment(Qt::AlignRight);