TheLanc3/QDiskInfo
1
0
Fork 0
mirror of https://github.com/edisionnano/QDiskInfo.git synced 2026-04-18 21:21:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused var, use as_const

Browse Source
This commit is contained in:
Spiros
2024-07-13 17:54:34 +03:00
parent d79f846e38
commit 81ba1e5754
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/mainwindow.cpp
View File

@@ -217,9 +217,9 @@ void MainWindow::updateUI()
QVector<QPair<QString, int>> nvmeSmartOrdered; QVector<QPair<QString, int>> nvmeSmartOrdered;
if (!isNvme) { if (!isNvme) {
for (const QJsonValue &attr : attributes) { for (const QJsonValue &attr : std::as_const(attributes)) {
QJsonObject attrObj = attr.toObject(); QJsonObject attrObj = attr.toObject();
if ((attrObj["id"] == 5 || attrObj["id"] == 197 || attrObj["id"] == 198 || (attrObj["id"] == 196 && !(ui->actionIgnore_C4_Reallocation_Event_Count->isChecked()))) && attrObj["raw"].toObject()["value"].toDouble()) { if ((attrObj["id"] == 5 || attrObj["id"] == 197 || attrObj["id"] == 198 || (attrObj["id"] == 196 && !(ui->actionIgnore_C4_Reallocation_Event_Count->isChecked()))) && attrObj["raw"].toObject()["value"].toDouble() > 0) {
caution = true; caution = true;
} }
if (attrObj["thresh"].toInt() && (attrObj["value"].toInt() < attrObj["thresh"].toInt())) { if (attrObj["thresh"].toInt() && (attrObj["value"].toInt() < attrObj["thresh"].toInt())) {
@@ -479,7 +479,7 @@ void MainWindow::populateWindow(const QJsonObject &localObj, const QString &heal
powerOnHoursLineEdit->setAlignment(Qt::AlignRight); powerOnHoursLineEdit->setAlignment(Qt::AlignRight);
if (!isNvme) { if (!isNvme) {
for (const QJsonValue &attr : attributes) { for (const QJsonValue &attr : std::as_const(attributes)) {
QJsonObject attrObj = attr.toObject(); QJsonObject attrObj = attr.toObject();
if (attrObj["id"] == 202) { if (attrObj["id"] == 202) {
if (attrObj["name"] == "Percent_Lifetime_Remain") { if (attrObj["name"] == "Percent_Lifetime_Remain") {
@@ -545,7 +545,7 @@ void MainWindow::populateWindow(const QJsonObject &localObj, const QString &heal
} }
} }
if (percentage.isEmpty() && rotationRate == "---- (SSD)") { // Workaround for some drives which have this and another attribute if (percentage.isEmpty() && rotationRate == "---- (SSD)") { // Workaround for some drives which have this and another attribute
for (const QJsonValue &attr : attributes) { for (const QJsonValue &attr : std::as_const(attributes)) {
QJsonObject attrObj = attr.toObject(); QJsonObject attrObj = attr.toObject();
if (attrObj["name"] == "Wear_Leveling_Count") { if (attrObj["name"] == "Wear_Leveling_Count") {
int percentageUsed = attrObj["value"].toInt(); int percentageUsed = attrObj["value"].toInt();
@@ -606,7 +606,7 @@ void MainWindow::populateWindow(const QJsonObject &localObj, const QString &heal
QString stringValue; QString stringValue;
warningTemperature = 65; warningTemperature = 65;
criticalTemperature = 70; criticalTemperature = 70;
for (const QJsonValue &value : outputArray) { for (const QJsonValue &value : std::as_const(outputArray)) {
stringValue = value.toString(); stringValue = value.toString();
if (stringValue.startsWith("Optional Admin Commands")) { if (stringValue.startsWith("Optional Admin Commands")) {
if (stringValue.contains("Self_Test")) { if (stringValue.contains("Self_Test")) {
@@ -717,8 +717,7 @@ void MainWindow::populateWindow(const QJsonObject &localObj, const QString &heal
selfTestMenu->setEnabled(true); selfTestMenu->setEnabled(true);
} }
int i = 0; for (const QString& key : std::as_const(keys)) {
for (const QString& key : keys) {
QString minutes = QString::number(pollingMinutes[key].toInt()); QString minutes = QString::number(pollingMinutes[key].toInt());
QString keyTranslated; QString keyTranslated;
if (key == "short") { if (key == "short") {
@@ -745,8 +744,6 @@ void MainWindow::populateWindow(const QJsonObject &localObj, const QString &heal
connect(action, &QAction::triggered, this, [this, mode, name, minutes]() { connect(action, &QAction::triggered, this, [this, mode, name, minutes]() {
Utils.selfTestHandler(mode, name, minutes); Utils.selfTestHandler(mode, name, minutes);
}); });
i++;
} }
if (ataSelfTestsTable.isEmpty()) { if (ataSelfTestsTable.isEmpty()) {