TheLanc3/QDiskInfo
1
0
Fork 0
mirror of https://github.com/edisionnano/QDiskInfo.git synced 2026-03-12 15:50:53 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add an error if smartctl does not exist or if pkexec is cancelled

Browse Source
This commit is contained in:
Spiros
2024-06-09 00:01:15 +03:00
parent 19a703f745
commit 3db4230d6c
2 changed files with 28 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
mainwindow.cpp
View File

@@ -630,11 +630,24 @@ void MainWindow::addSmartAttributesTable(const QJsonArray &attributes)
tableWidget->setEditTriggers(QAbstractItemView::NoEditTriggers);
}
bool commandExists(const QString &command) {
QStringList paths = QString::fromLocal8Bit(qgetenv("PATH")).split(QDir::listSeparator(), Qt::SkipEmptyParts);
for (const QString &path : paths) {
QString absolutePath = QDir(path).absoluteFilePath(command);
if (QFile::exists(absolutePath) && QFileInfo(absolutePath).isExecutable()) {
return true;
}
}
return false;
}
QString MainWindow::getSmartctlOutput(const QStringList &arguments, bool root)
{
QProcess process;
QString command;
QStringList commandArgs;
if (root) {
command = "pkexec";
commandArgs = QStringList();
@@ -643,9 +656,20 @@ QString MainWindow::getSmartctlOutput(const QStringList &arguments, bool root)
commandArgs = QStringList();
}
commandArgs.append(arguments);
process.start(command, commandArgs);
process.waitForFinished();
if (!commandExists("smartctl")) {
QMessageBox::critical(nullptr, tr("KDiskInfo Error"), tr("smartctl was not found, please install it!"));
QTimer::singleShot(0, qApp, &QApplication::quit);
} else {
commandArgs.append(arguments);
process.start(command, commandArgs);
process.waitForFinished(-1);
}
if (process.exitCode() == 127) {
QMessageBox::critical(nullptr, tr("KDiskInfo Error"), tr("KDiskInfo needs root access in order to read S.M.A.R.T. data!"));
QTimer::singleShot(0, qApp, &QApplication::quit);
}
return process.readAllStandardOutput();
}